r69086 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69085‎ | r69086 | r69087 >
Date:07:29, 6 July 2010
Author:philip
Status:ok
Tags:
Comment:
Follow up r69081. Use wfEmptyMsg() rather than the ugly comparison.
Modified paths:
  • /trunk/phase3/languages/LanguageConverter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/LanguageConverter.php
@@ -552,8 +552,9 @@
553553 } else {
554554 // first let's check if a message has given us a converted name
555555 $nsConvKey = 'conversion-ns' . $index;
556 - $text = wfMsgForContentNoTrans( $nsConvKey );
557 - if ( $text == '<' . htmlspecialchars( $nsConvKey ) . '>' ) {
 556+ if ( !wfEmptyMsg( $nsConvKey ) ) {
 557+ $text = wfMsgForContentNoTrans( $nsConvKey );
 558+ } else {
558559 // the message does not exist, try retrieve it from the current
559560 // variant's namespace names.
560561 $langObj = $this->mLangObj->factory( $variant );

Follow-up revisions

RevisionCommit summaryAuthorDate
r70187Merge r69080, r69081, r69085, r69086 from trunk: bug fixes of Language Conver...philip01:49, 30 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r690811. Fix the underline bug in the title(namespace) conversion, which displayed ...philip05:00, 6 July 2010

Status & tagging log