r69032 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69031‎ | r69032 | r69033 >
Date:23:04, 4 July 2010
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
Changes for 0.6.4 - Fixed OL style inclusion issue
Modified paths:
  • /trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php
——@@ -72,7 +72,7 @@
7373 global $egMapsStyleVersion, $egMapsJsExt, $egMapsScriptPath;
7474
7575 return array(
76 - Html::linkedScript( "$egMapsScriptPath/Services/OpenLayers/OpenLayers/theme/default/style.css" ),
 76+ Html::linkedStyle( "$egMapsScriptPath/Services/OpenLayers/OpenLayers/theme/default/style.css" ),
7777 Html::linkedScript( "$egMapsScriptPath/Services/OpenLayers/OpenLayers/OpenLayers.js?$egMapsStyleVersion" ),
7878 Html::linkedScript( "$egMapsScriptPath/Services/OpenLayers/OpenLayerFunctions{$egMapsJsExt}?$egMapsStyleVersion" ),
7979 Html::inlineScript( 'initOLSettings(200, 100);' )

Comments

#Comment by Ævar Arnfjörð Bjarmason (talk | contribs)   23:06, 4 July 2010

This commit makes Google Chrome like Maps again.

Interestingly, if you serve up a text/css in a <script> Firefox and Opera will just eat it as CSS, but Google Chrome refuses to do so.

#Comment by Ævar Arnfjörð Bjarmason (talk | contribs)   23:14, 4 July 2010

I filed a Chrome bug for this.

Status & tagging log