r68992 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68991‎ | r68992 | r68993 >
Date:11:39, 4 July 2010
Author:danny_b
Status:ok (Comments)
Tags:
Comment:
* Fixing (sub)section names - they can't have the same name, because they are used as id's in HTML.
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -750,7 +750,7 @@
751751 $defaultPreferences['rcdays'] = array(
752752 'type' => 'float',
753753 'label-message' => 'recentchangesdays',
754 - 'section' => 'rc/display',
 754+ 'section' => 'rc/displayrc',
755755 'min' => 1,
756756 'max' => ceil( $wgRCMaxAge / ( 3600 * 24 ) ),
757757 'help' => wfMsgExt(
@@ -763,7 +763,7 @@
764764 'type' => 'int',
765765 'label-message' => 'recentchangescount',
766766 'help-message' => 'prefs-help-recentchangescount',
767 - 'section' => 'rc/display',
 767+ 'section' => 'rc/displayrc',
768768 );
769769 $defaultPreferences['usenewrc'] = array(
770770 'type' => 'toggle',
@@ -807,7 +807,7 @@
808808 'type' => 'float',
809809 'min' => 0,
810810 'max' => 7,
811 - 'section' => 'watchlist/display',
 811+ 'section' => 'watchlist/displaywatchlist',
812812 'help' => wfMsgHtml( 'prefs-watchlist-days-max' ),
813813 'label-message' => 'prefs-watchlist-days',
814814 );
@@ -817,7 +817,7 @@
818818 'max' => 1000,
819819 'label-message' => 'prefs-watchlist-edits',
820820 'help' => wfMsgHtml( 'prefs-watchlist-edits-max' ),
821 - 'section' => 'watchlist/display',
 821+ 'section' => 'watchlist/displaywatchlist',
822822 );
823823 $defaultPreferences['extendwatchlist'] = array(
824824 'type' => 'toggle',
@@ -899,19 +899,19 @@
900900 $defaultPreferences['searchlimit'] = array(
901901 'type' => 'int',
902902 'label-message' => 'resultsperpage',
903 - 'section' => 'searchoptions/display',
 903+ 'section' => 'searchoptions/displaysearchoptions',
904904 'min' => 0,
905905 );
906906 $defaultPreferences['contextlines'] = array(
907907 'type' => 'int',
908908 'label-message' => 'contextlines',
909 - 'section' => 'searchoptions/display',
 909+ 'section' => 'searchoptions/displaysearchoptions',
910910 'min' => 0,
911911 );
912912 $defaultPreferences['contextchars'] = array(
913913 'type' => 'int',
914914 'label-message' => 'contextchars',
915 - 'section' => 'searchoptions/display',
 915+ 'section' => 'searchoptions/displaysearchoptions',
916916 'min' => 0,
917917 );
918918
@@ -920,7 +920,7 @@
921921 $defaultPreferences['disablesuggest'] = array(
922922 'type' => 'toggle',
923923 'label-message' => 'mwsuggest-disable',
924 - 'section' => 'searchoptions/display',
 924+ 'section' => 'searchoptions/displaysearchoptions',
925925 );
926926 }
927927
@@ -929,7 +929,7 @@
930930 $defaultPreferences['vector-simplesearch'] = array(
931931 'type' => 'toggle',
932932 'label-message' => 'vector-simplesearch-preference',
933 - 'section' => 'searchoptions/display'
 933+ 'section' => 'searchoptions/displaysearchoptions'
934934 );
935935 }
936936

Follow-up revisions

RevisionCommit summaryAuthorDate
r69500* missing messages for r68992danny_b09:56, 18 July 2010

Comments

#Comment by Nikerabbit (talk | contribs)   13:03, 16 July 2010

You forgot to rename the messages too. Now there is things like <prefs-displaysearchoptions> .

#Comment by Danny B. (talk | contribs)   09:58, 18 July 2010

Added in r69500.

Status & tagging log