| Index: trunk/extensions/CodeReview/CodeReview.i18n.php |
| — | — | @@ -89,6 +89,7 @@ |
| 90 | 90 | 'code-status-ok' => 'ok', |
| 91 | 91 | 'code-status-verified' => 'verified', |
| 92 | 92 | 'code-status-deferred' => 'deferred', |
| | 93 | + 'code-status-old' => 'old', |
| 93 | 94 | 'code-pathsearch-legend' => 'Search revisions in this repo by path', |
| 94 | 95 | 'code-pathsearch-path' => 'Path:', |
| 95 | 96 | 'code-pathsearch-filter' => 'Filter applied:', |
| Index: trunk/extensions/CodeReview/CodeReview.php |
| — | — | @@ -167,13 +167,19 @@ |
| 168 | 168 | $wgHooks['LoadExtensionSchemaUpdates'][] = 'efCodeReviewSchemaUpdates'; |
| 169 | 169 | |
| 170 | 170 | function efCodeReviewSchemaUpdates() { |
| 171 | | - global $wgDBtype, $wgExtNewFields, $wgExtPGNewFields, $wgExtNewIndexes, $wgExtNewTables; |
| | 171 | + global $wgDBtype, $wgExtNewFields, $wgExtPGNewFields, $wgExtNewIndexes, $wgExtNewTables, $wgExtModifiedFields; |
| 172 | 172 | $base = dirname( __FILE__ ); |
| 173 | 173 | if ( $wgDBtype == 'mysql' ) { |
| 174 | 174 | $wgExtNewTables[] = array( 'code_rev', "$base/codereview.sql" ); // Initial install tables |
| 175 | 175 | $wgExtNewFields[] = array( 'code_rev', 'cr_diff', "$base/archives/codereview-cr_diff.sql" ); |
| 176 | 176 | $wgExtNewIndexes[] = array( 'code_relations', 'repo_to_from', "$base/archives/code_relations_index.sql" ); |
| | 177 | + |
| 177 | 178 | // $wgExtNewFields[] = array( 'code_rev', "$base/archives/codereview-cr_status.sql" ); // FIXME FIXME this is a change to options... don't know how |
| | 179 | + |
| | 180 | + if ( !update_row_exists( 'add old to code_rev enum' ) ) { |
| | 181 | + $wgExtModifiedFields[] = array( 'code_rev', 'cr_status', "$base/archives/codereview-cr_old_status.sql" ); |
| | 182 | + } |
| | 183 | + |
| 178 | 184 | $wgExtNewTables[] = array( 'code_bugs', "$base/archives/code_bugs.sql" ); |
| 179 | 185 | $wgExtNewTables[] = array( 'code_test_suite', "$base/archives/codereview-code_tests.sql" ); |
| 180 | 186 | } elseif ( $wgDBtype == 'sqlite' ) { |
| Index: trunk/extensions/CodeReview/codereview.css |
| — | — | @@ -42,7 +42,6 @@ |
| 43 | 43 | padding-left: 48px; |
| 44 | 44 | } |
| 45 | 45 | |
| 46 | | - |
| 47 | 46 | .mw-codereview-status-new td { |
| 48 | 47 | background: #ffffc0 !important; |
| 49 | 48 | } |
| — | — | @@ -81,6 +80,10 @@ |
| 82 | 81 | color: #666; |
| 83 | 82 | } |
| 84 | 83 | |
| | 84 | +.mw-codereview-status-old td { |
| | 85 | + color: #666; |
| | 86 | +} |
| | 87 | + |
| 85 | 88 | .mw-codereview-success { |
| 86 | 89 | color: #1a2; |
| 87 | 90 | } |
| Index: trunk/extensions/CodeReview/archives/codereview-cr_old_status.sql |
| — | — | @@ -0,0 +1,6 @@ |
| | 2 | +ALTER TABLE /*$wgDBprefix*/code_rev |
| | 3 | + CHANGE `cr_status` `cr_status` |
| | 4 | + ENUM( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred', 'old' ) |
| | 5 | + NOT NULL DEFAULT 'new'; |
| | 6 | + |
| | 7 | +INSERT INTO /*$wgDBprefix*/updatelog( ul_key ) VALUES( 'add old to code_rev enum' ); |
| \ No newline at end of file |
| Property changes on: trunk/extensions/CodeReview/archives/codereview-cr_old_status.sql |
| ___________________________________________________________________ |
| Name: svn:eol-style |
| 1 | 8 | + native |
| Index: trunk/extensions/CodeReview/backend/CodeRevision.php |
| — | — | @@ -128,7 +128,7 @@ |
| 129 | 129 | } |
| 130 | 130 | |
| 131 | 131 | public static function getPossibleStates() { |
| 132 | | - return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred' ); |
| | 132 | + return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred', 'old' ); |
| 133 | 133 | } |
| 134 | 134 | |
| 135 | 135 | public function isValidStatus( $status ) { |
| Index: trunk/extensions/CodeReview/codereview.sql |
| — | — | @@ -53,7 +53,8 @@ |
| 54 | 54 | -- 'ok': Reviewed, no issues spotted |
| 55 | 55 | -- 'verified': Reviewed and tested, no issues spotted |
| 56 | 56 | -- 'deferred': Not reviewed at this time (usually non-Wikimedia extension) |
| 57 | | - cr_status enum('new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred') not null default 'new', |
| | 57 | + -- 'old': Predates the extension/doesn't require review |
| | 58 | + cr_status enum('new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred', 'old') not null default 'new', |
| 58 | 59 | |
| 59 | 60 | -- Base path of this revision : |
| 60 | 61 | -- * if the revision change only one file, the file path |