r68824 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68823‎ | r68824 | r68825 >
Date:09:48, 1 July 2010
Author:platonides
Status:resolved (Comments)
Tags:
Comment:
(bug 16886) Sister projects box moves down the extract of the first result in IE 7.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /trunk/phase3/skins/common/IE70Fixes.css (added) (history)

Diff [purge]

Index: trunk/phase3/skins/common/IE70Fixes.css
@@ -0,0 +1,12 @@
 2+/**
 3+ * Fixes sister projects box moving down the extract
 4+ * of the first result (bug #16886).
 5+ * It only happens when the window is small and
 6+ * This changes slightly the layout for big screens
 7+ * where there was space for the extracts and the
 8+ * sister projects and thus it showed like in any
 9+ * other browser.
 10+ */
 11+.searchresult {
 12+ display: inline;
 13+}
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -368,6 +368,9 @@
369369 $wgOut->setRobotPolicy( 'noindex,nofollow' );
370370 // add javascript specific to special:search
371371 $wgOut->addScriptFile( 'search.js' );
 372+
 373+ // Bug #16886: Sister projects box moves down the first extract on IE7
 374+ $wgOut->addStyle( 'common/IE80Fixes.css', 'screen', 'IE 7' );
372375 }
373376
374377 /**
@@ -608,7 +611,7 @@
609612 }
610613
611614 wfProfileOut( __METHOD__ );
612 - return "<li>{$link} {$redirect} {$section} {$extract}\n" .
 615+ return "<li><div class='mw-search-result-heading'>{$link} {$redirect} {$section}</div> {$extract}\n" .
613616 "<div class='mw-search-result-data'>{$score}{$size} - {$date}{$related}</div>" .
614617 "</li>\n";
615618
Index: trunk/phase3/RELEASE-NOTES
@@ -250,6 +250,7 @@
251251 * (bug 24089) Logevents causes PHP Notice if leprop=title isn't supplied
252252 * (bug 23473) Give description of properties on all modules
253253 * (bug 24136) unknownerror when adding new section without summary, but forceditsummary
 254+* (bug 16886) Sister projects box moves down the extract of the first result in IE 7.
254255
255256 === Languages updated in 1.17 ===
256257

Follow-up revisions

RevisionCommit summaryAuthorDate
r68825Follow up r68824 with eol styleplatonides09:52, 1 July 2010
r692947, it's 7! (follow up to r68824)platonides20:11, 12 July 2010

Comments

#Comment by Raymond (talk | contribs)   10:26, 1 July 2010
+		$wgOut->addStyle( 'common/IE80Fixes.css', 'screen', 'IE 7' );

IE8 or IE7?

#Comment by Raymond (talk | contribs)   16:19, 13 July 2010

Fixed in r69294. Thanks

Status & tagging log