r68734 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r68733‎ | r68734 | r68735 >
Date:19:19, 29 June 2010
Author:sergeychernyshev
Status:deferred (Comments)
Tags:
Comment:
Fixed failing tests - there is no need for additional spacing or \n (included incorrectly) in the code. Parser preserves original formatting.
Modified paths:
  • /trunk/extensions/PageObjectModel/POM/TemplateParameter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PageObjectModel/POM/TemplateParameter.php
——@@ -94,7 +94,7 @@
9595
9696 function toString()
9797 {
98 - return $this->name_triple->toString() . ' = ' . $this->value_triple->toString() . '\n';
 98+ return $this->name_triple->toString() . '=' . $this->value_triple->toString();
9999 }
100100 }
101101

Comments

#Comment by MaxSem (talk | contribs)   09:48, 30 June 2010

By the way, you can use UnitTestsList hook now to run your tests with core tests.

#Comment by Sergey Chernyshev (talk | contribs)   21:20, 1 July 2010

Thanks, I'll check it out! And they are PHPUnit which makes it easy to integrate (hopefully).

Status & tagging log