r68675 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68674‎ | r68675 | r68676 >
Date:19:07, 28 June 2010
Author:papyromancer
Status:deferred (Comments)
Tags:
Comment:
* code for css transformation spinner is in
* css transformation spinner is disabled
* mwEmbed_demo.html style changes and docs iframes disabled
Modified paths:
  • /branches/MwEmbedStandAlone/mwEmbed.js (modified) (history)
  • /branches/MwEmbedStandAlone/tests/mwEmbed_Demo.html (modified) (history)
  • /branches/MwEmbedStandAlone/tests/style.css (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/mwEmbed.js
@@ -2123,13 +2123,39 @@
21242124 */
21252125 $.fn.loadingSpinner = function( ) {
21262126 if ( this ) {
2127 - $j( this ).html(
2128 - $j( '<div />' )
2129 - .addClass( "loadingSpinner" )
2130 - );
2131 - }
 2127+ var csstransforms = false;
 2128+ if ( csstransforms ) {
 2129+ var barNumber = 7;
 2130+ var barContent = '';
 2131+ var barSpacingDegrees = 360 / barNumber;
 2132+ var barOpacityDelta = 1 / (barNumber)
 2133+ for (i = 1; i < barNumber+1; i++) {
 2134+ barContent += '<div class="bar' + i + '" style="-moz-transform:rotate(' + (i-1) * barSpacingDegrees + 'deg) translate(0, -40px);-webkit-transform:rotate(' + (i-1) * barSpacingDegrees + 'deg) translate(0, -40px);opacity:' + (i) * barOpacityDelta + '; background:#000"/>';
 2135+ }
 2136+ $j( this ).html(
 2137+ $j( '<div />' )
 2138+ .addClass( "cssLoadingSpinner" )
 2139+ .html( barContent )
 2140+ );
 2141+ var rotations = 0;
 2142+ setInterval( function ( ) {
 2143+ $j('.cssLoadingSpinner')
 2144+ .css('-moz-transform','rotate('+rotations+'deg)')
 2145+ .css('-webkit-transform','rotate('+rotations+'deg)');
 2146+ if( rotations == 360 ) {
 2147+ rotations = 0;
 2148+ }
 2149+ rotations += 5;
 2150+ }, 25);
 2151+ }
 2152+ else {
 2153+ $j( this ).html(
 2154+ $j( '<div />' )
 2155+ .addClass( "loadingSpinner" )
 2156+ );
 2157+ }
21322158 return this;
2133 - }
 2159+ }}
21342160
21352161 /**
21362162 * dragDrop file loader
Index: branches/MwEmbedStandAlone/tests/mwEmbed_Demo.html
@@ -3,12 +3,12 @@
44 <head>
55 <title>mwEmbed Testing Kit</title>
66
 7+ <link rel="stylesheet" href="style.css" type="text/css" media="screen" />
 8+ <script type="text/javascript" src="jslib/jquery.js"></script>
79 <link type="text/css" rel="stylesheet" href="jslib/syntax/prettify.css" />
810 <link rel="stylesheet" type="text/css" media="screen" href="jslib/menu/css/superfish.css" />
911 <link rel="stylesheet" type="text/css" media="screen" href="jslib/menu/css/superfish-vertical.css" />
10 - <link rel="stylesheet" href="style.css" type="text/css" media="screen" />
11 -
12 - <script type="text/javascript" src="jslib/jquery.js"></script>
 12+
1313 <script type="text/javascript" src="jslib/syntax/prettify.js"></script>
1414 <script type="text/javascript" src="jslib/menu/hoverIntent.js"></script>
1515 <script type="text/javascript" src="jslib/menu/superfish.js"></script>
@@ -16,8 +16,13 @@
1717
1818 <script type="text/javascript" src="../libraries/jquery/jquery.ui/ui/ui.resizable.js"></script>
1919 <script type="text/javascript" src="../libraries/jquery/jquery.ui/ui/ui.draggable.js"></script>
 20+
 21+
 22+ <script type="text/javascript" src="../mwEmbed.js?debug=true"></script>
 23+ <!--
2024 <script type="text/javascript" src="http://html5.kaltura.org/js" > </script>
21 - <!-- <script type="text/javascript" src="../mwEmbed.js?debug=true"></script> -->
 25+
 26+ -->
2227
2328 <script type="text/javascript">
2429 $(function () {
@@ -56,8 +61,8 @@
5762 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/b/bd/Elephants_Dream.ogg/seek%3D13-Elephants_Dream.ogg.jpg"
5863 duration="10:53"
5964 linkback="http://www.elephantsdream.org/" >
60 - <source type="video/ogg" src="http://ia311040.us.archive.org/3/items/ElephantsDream/ed_1024.ogv" >
61 - <source type="video/h264" src="http://ia311040.us.archive.org/3/items/ElephantsDream/ed_hd_512kb.mp4" >
 65+ <source type="video/webm" src="media/out500.webm" >
 66+ <source type="video/ogg" src="media/out500.ogv" >
6267
6368 <!-- Subtitles -->
6469
@@ -175,7 +180,7 @@
176181
177182 </div><!-- END demo_player -->
178183
179 - <div id="docbox" class="ui-widget-content">
 184+ <!-- <div id="docbox" class="ui-widget-content">
180185 <h3 class="ui-widget-header">mwEmbed Documentation</h3>
181186 <p> there will be a menu here to switch between the README and the generated docs</p>
182187 <div id="jsdocs">
@@ -183,16 +188,16 @@
184189 </iframe>
185190 </div>
186191
187 - </div><!-- end sideBox -->
 192+ </div> end sideBox -->
188193
189 - <div id="js-console" class="ui-widget-content">
 194+ <!-- <div id="js-console" class="ui-widget-content">
190195 <h3 class="ui-widget-header">mwEmbed Controls</h3>
191196 <p>Textboxes and buttons for interacting with the demonstration player.</p>
192197 </div>
193198
194199 <div id="help" style="display:none;">
195200 <p>Instructions will go here</p>
196 - </div><!-- END help -->
 201+ </div> END help -->
197202
198203
199204 </div><!-- END content -->
Index: branches/MwEmbedStandAlone/tests/style.css
@@ -8,8 +8,8 @@
99 body, td, th, pre, code, select, option, input, textarea {
1010 font-family:"Trebuchet MS", Arial, Sans-serif;
1111 font-size:10pt;
12 - color: white;
13 - background-color: black;
 12+ color: black;
 13+ background-color: white;
1414 }
1515
1616 #container { width:700px; margin:10px auto; overflow:hidden; }

Comments

#Comment by Mdale (talk | contribs)   19:24, 29 June 2010

remember to use tabs not spaces, and match jQuery chain formating with the rest of the code base.

Status & tagging log