r68499 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68498‎ | r68499 | r68500 >
Date:02:58, 24 June 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fix documentation problem from r62934: you can't call a non-static method statically E__STRICT-compliant PHP, and certainly not if the method references $this.
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRepository.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -76,7 +76,6 @@
7777 /**
7878 * Like getId(), but returns the result as a string, including prefix,
7979 * i.e. "r123" instead of 123.
80 - * May be called statically if you pass the $id in.
8180 */
8281 public function getIdString( $id = null ) {
8382 if ( $id === null ) {
Index: trunk/extensions/CodeReview/backend/CodeRepository.php
@@ -175,7 +175,6 @@
176176 /**
177177 * Returns the supplied revision ID as a string ready for output, including the
178178 * appropriate (localisable) prefix (e.g. "r123" instead of 123).
179 - * May be called statically.
180179 */
181180 public function getRevIdString( $id ) {
182181 return wfMsg( 'code-rev-id', $id );
@@ -189,7 +188,6 @@
190189 * confusing (e.g. in e-mails, page titles etc.). If only one repository is
191190 * defined then this returns the same as getRevIdString() as there
192191 * is no ambiguity.
193 - * May NOT be called statically.
194192 */
195193 public function getRevIdStringUnique( $id ) {
196194 $id = wfMsg( 'code-rev-id', $id );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62934CodeReview: Modified the method we use to output the revision ID. If more th...happydog18:50, 24 February 2010

Status & tagging log