r68494 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68493‎ | r68494 | r68495 >
Date:00:23, 24 June 2010
Author:dale
Status:deferred
Tags:
Comment:
* added msgs.
* renderTime for basic playback
Modified paths:
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/SmilPlayer.i8n.php (modified) (history)
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/mw.EmbedPlayerSmil.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilBody.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilBuffer.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilBody.js
@@ -73,7 +73,6 @@
7474
7575 /**
7676 * Gets all the elements for a given time.
77 - *
7877 */
7978 getElementsForTime: function ( time ) {
8079 var startOffset = 0;
@@ -84,7 +83,7 @@
8584 this.elementsInRange = [];
8685 this.getElementsForTimeRecurse( this.$dom, time, startOffset);
8786 return this.elementsInRange;
88 - },
 87+ },
8988
9089 /**
9190 * getElementsForTimeRecurse
Index: branches/MwEmbedStandAlone/modules/SmilPlayer/SmilPlayer.i8n.php
@@ -0,0 +1,6 @@
 2+<?php
 3+$messages = array();
 4+
 5+$messages['en'] = array(
 6+ 'mwe-embedplayer-ogg-player-smilPlayer' => 'SMIL Player'
 7+);
\ No newline at end of file
Index: branches/MwEmbedStandAlone/modules/SmilPlayer/mw.EmbedPlayerSmil.js
@@ -123,7 +123,7 @@
124124 * Get the embed player time
125125 */
126126 getPlayerElementTime: function() {
127 - return this.smilPlayTime;
 127+ return this.smilPlayTime;
128128 },
129129
130130 /**
@@ -133,7 +133,14 @@
134134 // Update the smilPlayTime
135135 if( !this.isPaused() ){
136136 this.smilPlayTime = this.smilPauseTime + ( ( new Date().getTime() - this.clockStartTime ) / 1000 );
137 - }
 137+ }
 138+
 139+ // Render time
 140+ smil.renderTime( this.smilPlayTime, function(){
 141+ // callback for render
 142+
 143+ // xxx if too much time has gone by potentaill flag
 144+ });
138145 this.parent_monitor();
139146 },
140147
Index: branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilBuffer.js
@@ -7,7 +7,9 @@
88 }
99
1010 mw.SmilBuffer.prototype = {
11 - // Constructor:
 11+ /**
 12+ * Constructor:
 13+ */
1214 init: function( smilObject ) {
1315 this.smil = smilObject;
1416 },
@@ -23,7 +25,7 @@
2426
2527 // setTimeout to call self until buffer is ready
2628
27 - // temp ( assume ready ):
 29+ // Temp ( assume ready ):
2830 callback();
2931 }
3032 }
\ No newline at end of file

Status & tagging log