r68493 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68492‎ | r68493 | r68494 >
Date:00:12, 24 June 2010
Author:juliano
Status:deferred
Tags:
Comment:
Followup r67090, for source-code readability.
Modified paths:
  • /trunk/extensions/Wikilog/Wikilog.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogCommentsPage.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogHooks.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogItemPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/WikilogItemPager.php
@@ -441,7 +441,7 @@
442442 $value = isset( $row->$field ) ? $row->$field : null;
443443 $formatted = strval( $this->formatValue( $field, $value ) );
444444 if ( $formatted == '' ) {
445 - $formatted = ' ';
 445+ $formatted = WL_NBSP;
446446 }
447447 $class = 'TablePager_col_' . htmlspecialchars( $field );
448448 $columns[] = "<td class=\"$class\">$formatted</td>";
Index: trunk/extensions/Wikilog/Wikilog.php
@@ -42,6 +42,15 @@
4343 );
4444
4545 /*
 46+ * Constant definitions.
 47+ */
 48+// For source-code readability. This ought to be defined by MediaWiki (and
 49+// there is actually such a definition in DifferenceEngine.php, but it is
 50+// not global). So, it is easier to have our own until MediaWiki provides
 51+// one globally. It also allows us to keep compatibility.
 52+define( 'WL_NBSP', '&#160;' );
 53+
 54+/*
4655 * Dependencies.
4756 */
4857 require_once( dirname( __FILE__ ) . '/WlFeed.php' );
Index: trunk/extensions/Wikilog/WikilogCommentsPage.php
@@ -355,7 +355,7 @@
356356 }
357357
358358 $fields[] = array( '',
359 - Xml::submitbutton( wfMsg( 'wikilog-submit' ), array( 'name' => 'wlActionCommentSubmit' ) ) . '&#160;' .
 359+ Xml::submitbutton( wfMsg( 'wikilog-submit' ), array( 'name' => 'wlActionCommentSubmit' ) ) . WL_NBSP .
360360 Xml::submitbutton( wfMsg( 'wikilog-preview' ), array( 'name' => 'wlActionCommentPreview' ) )
361361 );
362362
Index: trunk/extensions/Wikilog/WikilogHooks.php
@@ -301,7 +301,7 @@
302302 Xml::check( 'wlSignpub', $checked, array(
303303 'id' => 'wl-signpub',
304304 'tabindex' => 1, // after text, before summary
305 - ) ) . '&#160;' .
 305+ ) ) . WL_NBSP .
306306 Xml::element( 'label', array(
307307 'for' => 'wl-signpub',
308308 'title' => $tooltip,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67090Remove most named character references from output...simetrical17:33, 30 May 2010

Status & tagging log