r68364 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68363‎ | r68364 | r68365 >
Date:16:40, 21 June 2010
Author:ialex
Status:deferred (Comments)
Tags:
Comment:
Removed unused globals
Modified paths:
  • /trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php (modified) (history)
  • /trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMaps.php
@@ -93,7 +93,6 @@
9494 * @return array
9595 */
9696 protected function getDependencies() {
97 - global $wgJsMimeType;
9897 global $egYahooMapsKey, $egMapsScriptPath, $egMapsStyleVersion, $egMapsJsExt;
9998
10099 return array(
Index: trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php
@@ -69,7 +69,6 @@
7070 * @return array
7171 */
7272 protected function getDependencies() {
73 - global $wgJsMimeType;
7473 global $egMapsStyleVersion, $egMapsJsExt, $egMapsScriptPath;
7574
7675 return array(
@@ -140,7 +139,6 @@
141140 * @param string $layer The layer to check (and load the dependencies for
142141 */
143142 public function loadDependencyWhenNeeded( $layer ) {
144 - global $wgJsMimeType;
145143 global $egMapsOLAvailableLayers, $egMapsOLLayerDependencies, $egMapsOLLoadedLayers;
146144
147145 // Check if there is a dependency refered by the layer definition.
Index: trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php
@@ -233,7 +233,7 @@
234234 * FIXME: layer onload function kills maps for some reason
235235 */
236236 public function addOverlayOutput( &$output, $mapName, $overlays, $controls ) {
237 - global $egMapsGMapOverlays, $egMapsGoogleOverlLoaded, $wgJsMimeType;
 237+ global $egMapsGMapOverlays, $egMapsGoogleOverlLoaded;
238238
239239 // Check to see if there is an overlays control.
240240 $hasOverlayControl = in_string( 'overlays', $controls );

Comments

#Comment by Jeroen De Dauw (talk | contribs)   17:03, 21 June 2010

Thanks :)

Status & tagging log