r68348 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r68347‎ | r68348 | r68349 >
Date:11:15, 21 June 2010
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Follow-up r68324: Add usage of PLURAL to message 'file-info-png-repeat'. Code already supports PLURAL (wfMsgExt with parseinline).
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
——@@ -3553,7 +3553,7 @@
35543554 'file-info-gif-looped' => 'looped',
35553555 'file-info-gif-frames' => '$1 {{PLURAL:$1|frame|frames}}',
35563556 'file-info-png-looped' => 'looped',
3557 -'file-info-png-repeat' => 'played $1 times',
 3557+'file-info-png-repeat' => 'played $1 {{PLURAL:$1|time|times}}',
35583558 'file-info-png-frames' => '$1 {{PLURAL:$1|frame|frames}}',
35593559
35603560 # Special:NewFiles

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68324Add a new PNG parser in order to recognize APNG (animated PNG) images.hartman16:09, 20 June 2010

Comments

#Comment by TheDJ (talk | contribs)   12:00, 21 June 2010

FYI, the message is only shown if plural, so this is not a current usecase.

#Comment by Siebrand (talk | contribs)   12:07, 21 June 2010

Not all languages have one plural form, and to avoid questions and remarks from translators, this was done for completeness sake.

Status & tagging log