r68312 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68311‎ | r68312 | r68313 >
Date:13:40, 20 June 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Followup r68167, getPrefixedText() isn't escaped properly. Use link() for all of these instead
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php
@@ -67,15 +67,18 @@
6868 global $wgLang;
6969 $title = Title::makeTitle( $row->page_namespace, $row->page_title );
7070 # Link to page
71 - $link = $this->skin->makeKnownLinkObj( $title, $title->getPrefixedText() );
 71+ $link = $this->skin->link( $title );
7272 # Helpful utility links
7373 $utilLinks = array();
74 - $utilLinks[] = $this->skin->makeKnownLinkObj( $title,
75 - wfMsgHtml( 'stablepages-config' ), 'action=protect' );
76 - $utilLinks[] = $this->skin->makeKnownLinkObj( $title,
77 - wfMsgHtml( 'history' ), 'action=history' );
78 - $utilLinks[] = $this->skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Log/stable' ),
79 - wfMsgHtml( 'stable-logpage' ), 'page=' . $title->getPrefixedText() );
 74+ $utilLinks[] = $this->skin->link( $title,
 75+ wfMsgHtml( 'stablepages-config' ),
 76+ array(), array( 'action' => 'protect' ) );
 77+ $utilLinks[] = $this->skin->link( $title,
 78+ wfMsgHtml( 'history' ),
 79+ array(), array( 'action' => 'history' ) );
 80+ $utilLinks[] = $this->skin->link( SpecialPage::getTitleFor( 'Log/stable' ),
 81+ wfMsgHtml( 'stable-logpage' ),
 82+ array(), array( 'page' => $title->getPrefixedText() ) );
8083 # Autoreview/review restriction level
8184 $restr = '';
8285 if( $row->fpc_level != '' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r68315Followup r68312, use getTitleFor() how it's documented, not what just happene...demon13:53, 20 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68167(bug 23989) Add page history and stability log links to entries on Special:St...demon12:01, 17 June 2010

Comments

#Comment by Nikerabbit (talk | contribs)   13:50, 20 June 2010

Calling:

-SpecialPage::getTitleFor( 'Log/stable' )
+SpecialPage::getTitleFor( 'Log', 'stable' )


You also changed makeKnownLinkObj() to just link(), was that intented?

Status & tagging log