r68231 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68230‎ | r68231 | r68232 >
Date:19:21, 18 June 2010
Author:daniel
Status:ok
Tags:
Comment:
follop-up to 68230: forgot to commit the styles needed for layout grids
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -877,3 +877,16 @@
878878 a.sortheader {
879879 margin: 0 0.3em;
880880 }
 881+
 882+.grid-table {
 883+ display: table;
 884+}
 885+
 886+.grid-row {
 887+ display: table-row;
 888+}
 889+
 890+.grid-cell {
 891+ display: table-cell;
 892+ padding: 0.33ex;
 893+}
Index: trunk/phase3/includes/parser/Parser.php
@@ -836,9 +836,9 @@
837837 $td_tag = 'div';
838838 $caption_tag = 'div';
839839
840 - $extra_table_attribs = array( 'class' => 'grid-table', 'style' => 'display:table;' );
841 - $extra_tr_attribs = array( 'class' => 'grid-row', 'style' => 'display:table-row;' );
842 - $extra_td_attribs = array( 'class' => 'grid-cell', 'style' => 'display:table-cell;' );
 840+ $extra_table_attribs = array( 'class' => 'grid-table' );
 841+ $extra_tr_attribs = array( 'class' => 'grid-row' );
 842+ $extra_td_attribs = array( 'class' => 'grid-cell' );
843843
844844 $convert_style = true;
845845 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r781771.17: Back out r68230 (mode="grid" on wiki table triggers div soup instead of...catrope12:10, 10 December 2010
r78196Revert r68230, r68231 (mode="grid" on tables) per CR. It's in the history if ...demon16:03, 10 December 2010

Status & tagging log