r68161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68160‎ | r68161 | r68162 >
Date:09:39, 17 June 2010
Author:catrope
Status:ok
Tags:
Comment:
Followup to r68157: simplify ApiQueryUsers::getAutoGroups()
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -225,15 +225,7 @@
226226 * @return array
227227 */
228228 public static function getAutoGroups( $user ) {
229 - $autolist = array();
230 - $autolist[] = "*";
231 - $autolist[] = "user";
232 -
233 - foreach( Autopromote::getAutopromoteGroups( $user ) as $group ) {
234 - $autolist[] = $group;
235 - }
236 -
237 - return $autolist;
 229+ return array_merge( array( '*', 'user' ), Autopromote::getAutopromoteGroups( $user ) );
238230 }
239231
240232 public function getAllowedParams() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r68331Followup r68157 and r68161 per Bryans comment (anons aren't in the group user)reedy17:30, 20 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68157Minor followup to r68156, add "user" as implicit group...reedy08:00, 17 June 2010

Status & tagging log