r68108 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68107‎ | r68108 | r68109 >
Date:22:27, 15 June 2010
Author:adam
Status:deferred
Tags:
Comment:
Simple and Expandable Search - fixing allignment of the magnifying glass button, and fixing expandable search in IE6/7
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Modules/ExpandableSearch/ExpandableSearch.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/vector.expandableSearch.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/vector.expandableSearch.css
@@ -5,5 +5,7 @@
66 overflow: auto;
77 }
88 div#simpleSearch button#searchButton {
9 - margin: 3px 0 0 0;
 9+ margin: 5px 5px 0 0;
 10+ height: 13px;
 11+ width: 12px;
1012 }
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -140,7 +140,9 @@
141141 overflow: auto;
142142 }
143143 div#simpleSearch button#searchButton {
144 - margin: 3px 0 0 0;
 144+ margin: 5px 5px 0 0;
 145+ height: 13px;
 146+ width: 12px;
145147 }
146148 /* wikiEditor plugin */
147149
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -138,7 +138,9 @@
139139 overflow:auto;
140140 }
141141 div#simpleSearch button#searchButton{
142 -margin:3px 0 0 0;
 142+margin:5px 5px 0 0;
 143+height:13px;
 144+width:12px;
143145 }
144146 form#editform{
145147 margin:0;
Index: trunk/extensions/UsabilityInitiative/Vector/Modules/ExpandableSearch/ExpandableSearch.js
@@ -69,5 +69,5 @@
7070 } )
7171 .css( 'float', $j( 'body' ).is( '.rtl' ) ? 'right' : 'left' )
7272 .siblings( 'button' )
73 - .css( 'float', $j( 'body' ).is( '.rtl' ) ? 'left' : 'right' );
 73+ .css( 'float', $j( 'body' ).is( '.rtl' ) ? 'right' : 'left' );
7474 });
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -20,10 +20,10 @@
2121 array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 17 ),
2222 ),
2323 'combined' => array(
24 - array( 'src' => 'Vector.combined.js', 'version' => 53 ),
 24+ array( 'src' => 'Vector.combined.js', 'version' => 54 ),
2525 ),
2626 'minified' => array(
27 - array( 'src' => 'Vector.combined.min.js', 'version' => 54 ),
 27+ array( 'src' => 'Vector.combined.min.js', 'version' => 55 ),
2828 ),
2929 );
3030 static $modules = array(
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js
@@ -411,7 +411,7 @@
412412 } )
413413 .css( 'float', $j( 'body' ).is( '.rtl' ) ? 'right' : 'left' )
414414 .siblings( 'button' )
415 - .css( 'float', $j( 'body' ).is( '.rtl' ) ? 'left' : 'right' );
 415+ .css( 'float', $j( 'body' ).is( '.rtl' ) ? 'right' : 'left' );
416416 });
417417 /* Prototype code to demonstrate proposed edit page footer cleanups */
418418 /* First draft and will be changing greatly */
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js
@@ -20,7 +20,7 @@
2121 if(wgAction=='submit'||$j('#wpTextbox1').data('origtext')!=$j('#wpTextbox1').val()||$j('#wpSummary').data('origtext')!=$j('#wpSummary').val()){return mw.usability.getMsg('vector-editwarning-warning');}}
2222 $j('form').submit(function(){window.onbeforeunload=fallbackWindowOnBeforeUnload;});});var fallbackWindowOnBeforeUnload=null;$j(document).ready(function(){if(!wgVectorEnabledModules.expandablesearch||skin!='vector'){return true;}
2323 var map={'ltr':{'msie':[['>=',8]],'blackberry':false,'ipod':false,'iphone':false,'ps3':false},'rtl':{'msie':[['>=',8]],'blackberry':false,'ipod':false,'iphone':false,'ps3':false}};if(!mw.usability.testBrowser(map)){return true;}
24 -$j('#searchInput').expandableField({'beforeExpand':function(context){$j(this).parent().animate({'borderTopColor':'#a0d8ff','borderLeftColor':'#a0d8ff','borderRightColor':'#a0d8ff','borderBottomColor':'#a0d8ff'},'fast');},'beforeCondense':function(context){$j(this).parent().animate({'borderTopColor':'#aaaaaa','borderLeftColor':'#aaaaaa','borderRightColor':'#aaaaaa','borderBottomColor':'#aaaaaa'},'fast');},'afterExpand':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}},'afterCondense':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}},'expandToLeft':!$j('body').is('.rtl')}).css('float',$j('body').is('.rtl')?'right':'left').siblings('button').css('float',$j('body').is('.rtl')?'left':'right');});$j(document).ready(function(){if(!wgVectorEnabledModules.footercleanup){return true;}
 24+$j('#searchInput').expandableField({'beforeExpand':function(context){$j(this).parent().animate({'borderTopColor':'#a0d8ff','borderLeftColor':'#a0d8ff','borderRightColor':'#a0d8ff','borderBottomColor':'#a0d8ff'},'fast');},'beforeCondense':function(context){$j(this).parent().animate({'borderTopColor':'#aaaaaa','borderLeftColor':'#aaaaaa','borderRightColor':'#aaaaaa','borderBottomColor':'#aaaaaa'},'fast');},'afterExpand':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}},'afterCondense':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}},'expandToLeft':!$j('body').is('.rtl')}).css('float',$j('body').is('.rtl')?'right':'left').siblings('button').css('float',$j('body').is('.rtl')?'right':'left');});$j(document).ready(function(){if(!wgVectorEnabledModules.footercleanup){return true;}
2525 $j('#editpage-copywarn').add('.editOptions').wrapAll('<div id="editpage-bottom"></div>');$j('#wpSummary').data('hint',$j('#wpSummaryLabel span small').remove().text().replace(/\)|\(/g,'')).change(function(){if($j(this).val().length==0){$j(this).addClass('inline-hint').val($j(this).data('hint'));}else{$j(this).removeClass('inline-hint');}}).focus(function(){if($j(this).val()==$j(this).data('hint')){$j(this).removeClass('inline-hint').val("");}}).blur(function(){$j(this).trigger('change');}).trigger('change');$j('#wpSummary').add('.editCheckboxes').wrapAll('<div id="editpage-summary-fields"></div>');$j('#editpage-specialchars').remove();var transclusionCount=$j('.templatesUsed ul li').size();$j('.templatesUsed ul').wrap('<div id="transclusions-list" class="collapsible-list collapsed"></div>').parent().prepend('<label>This page contains <a href="http://en.wikipedia.org/wiki/transclusion">transclusions</a> of <strong>'
2626 +transclusionCount
2727 +'</strong> other pages.</label>');$j('.mw-templatesUsedExplanation').remove();$j('.collapsible-list label').click(function(){$j(this).parent().toggleClass('expanded').toggleClass('collapsed').find('ul').slideToggle('fast');return false;}).trigger('click');$j('#wpPreview, #wpDiff, .editHelp, #editpage-specialchars').remove();$j('#mw-editform-cancel').remove().appendTo('.editButtons');});if(wgVectorEnabledModules.simplesearch&&skin=='vector'&&typeof os_autoload_inputs!=='undefined'&&os_autoload_forms!=='undefined'){os_autoload_inputs=[];os_autoload_forms=[];}
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -30,11 +30,11 @@
3131 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3232 ),
3333 'combined' => array(
34 - array( 'src' => 'css/combined.css', 'version' => 104 ),
 34+ array( 'src' => 'css/combined.css', 'version' => 106 ),
3535 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3636 ),
3737 'minified' => array(
38 - array( 'src' => 'css/combined.min.css', 'version' => 104 ),
 38+ array( 'src' => 'css/combined.min.css', 'version' => 106 ),
3939 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
4040 ),
4141 )
@@ -80,10 +80,10 @@
8181 array( 'src' => 'js/thirdparty/contentCollector.js', 'version' => 2 ),
8282 ),
8383 'combined' => array(
84 - array( 'src' => 'js/plugins.combined.js', 'version' => 434 ),
 84+ array( 'src' => 'js/plugins.combined.js', 'version' => 435 ),
8585 ),
8686 'minified' => array(
87 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 435 ),
 87+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 437 ),
8888 ),
8989 ),
9090 );
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -22,10 +22,10 @@
2323 array( 'src' => 'Modules/AddMediaWizard/AddMediaWizard.js', 'version' => 6 ),
2424 ),
2525 'combined' => array(
26 - array( 'src' => 'WikiEditor.combined.js', 'version' => 100 ),
 26+ array( 'src' => 'WikiEditor.combined.js', 'version' => 101 ),
2727 ),
2828 'minified' => array(
29 - array( 'src' => 'WikiEditor.combined.min.js', 'version' => 100 ),
 29+ array( 'src' => 'WikiEditor.combined.min.js', 'version' => 101 ),
3030 ),
3131 );
3232 static $messages = array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r68109Complimetary CSS changes for r68108. Changes here pertaining to consistency i...adam22:29, 15 June 2010

Status & tagging log