r67920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67919‎ | r67920 | r67921 >
Date:21:00, 12 June 2010
Author:ialex
Status:ok
Tags:
Comment:
Fixed some doxygen warnings
Modified paths:
  • /trunk/phase3/maintenance/namespaceDupes.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/namespaceDupes.php
@@ -62,8 +62,8 @@
6363
6464 /**
6565 * @todo Document
66 - * @param $fix bool Whether or not to fix broken entries
67 - * @param $suffix String Suffix to append to renamed articles
 66+ * @param $fix Boolean: whether or not to fix broken entries
 67+ * @param $suffix String: suffix to append to renamed articles
6868 */
6969 private function checkAll( $fix, $suffix = '' ) {
7070 global $wgContLang, $wgNamespaceAliases, $wgCanonicalNamespaceNames;
@@ -132,8 +132,9 @@
133133
134134 /**
135135 * Get the interwiki list
 136+ *
136137 * @todo Needs to respect interwiki cache!
137 - * @return array
 138+ * @return Array
138139 */
139140 private function getInterwikiList() {
140141 $result = $this->db->select( 'interwiki', array( 'iw_prefix' ) );
@@ -147,10 +148,10 @@
148149
149150 /**
150151 * @todo Document
151 - * @param $ns int A namespace id
 152+ * @param $ns Integer: a namespace id
152153 * @param $name String
153 - * @param $fix bool Whether to fix broken entries
154 - * @param $suffix String Suffix to append to renamed articles
 154+ * @param $fix Boolean: whether to fix broken entries
 155+ * @param $suffix String: suffix to append to renamed articles
155156 */
156157 private function checkNamespace( $ns, $name, $fix, $suffix = '' ) {
157158 $conflicts = $this->getConflicts( $ns, $name );
@@ -181,8 +182,9 @@
182183 /**
183184 * Find pages in mainspace that have a prefix of the new namespace
184185 * so we know titles that will need migrating
185 - * @param $ns int Namespace id (id for new namespace?)
186 - * @param $name String Prefix that is being made a namespace
 186+ *
 187+ * @param $ns Integer: namespace id (id for new namespace?)
 188+ * @param $name String: prefix that is being made a namespace
187189 */
188190 private function getConflicts( $ns, $name ) {
189191 $page = 'page';
@@ -252,9 +254,10 @@
253255
254256 /**
255257 * Resolve any conflicts
256 - * @param $row Row from the page table to fix
257 - * @param $resolveable bool
258 - * @param $suffix String Suffix to append to the fixed page
 258+ *
 259+ * @param $row Object: row from the page table to fix
 260+ * @param $resolvable Boolean
 261+ * @param $suffix String: suffix to append to the fixed page
259262 */
260263 private function resolveConflict( $row, $resolvable, $suffix ) {
261264 if ( !$resolvable ) {
@@ -281,9 +284,10 @@
282285
283286 /**
284287 * Resolve a given conflict
285 - * @param $row Row from the old broken entry
286 - * @param $table String Table to update
287 - * @param $prefix String Prefix for column name, like page or ar
 288+ *
 289+ * @param $row Object: row from the old broken entry
 290+ * @param $table String: table to update
 291+ * @param $prefix String: prefix for column name, like page or ar
288292 */
289293 private function resolveConflictOn( $row, $table, $prefix ) {
290294 $this->output( "... resolving on $table... " );

Status & tagging log