r67919 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67918‎ | r67919 | r67920 >
Date:20:36, 12 June 2010
Author:ialex
Status:ok
Tags:
Comment:
Removed some unused globals
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -91,8 +91,7 @@
9292 * Adds the modules to the edit form
9393 */
9494 public static function addModules() {
95 - global $wgUser, $wgJsMimeType, $wgOut;
96 - global $wgVectorModules, $wgUsabilityInitiativeResourceMode;
 95+ global $wgUser, $wgVectorModules, $wgUsabilityInitiativeResourceMode;
9796
9897 // Don't load Vector modules for non-Vector skins
9998 // They won't work but will throw unused JS in the client's face
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -387,8 +387,7 @@
388388 * Adds the modules to the edit form
389389 */
390390 public static function addModules( &$toolbar ) {
391 - global $wgOut, $wgUser, $wgJsMimeType;
392 - global $wgWikiEditorModules, $wgUsabilityInitiativeResourceMode;
 391+ global $wgUser, $wgWikiEditorModules, $wgUsabilityInitiativeResourceMode;
393392
394393 // Modules
395394 $preferences = array();

Status & tagging log