r67893 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67892‎ | r67893 | r67894 >
Date:10:59, 12 June 2010
Author:hartman
Status:ok (Comments)
Tags:
Comment:
Follow up to r67703. Fixes jump-to anchor which still ref'ed to #head instead of mw-head
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -505,7 +505,7 @@
506506 <?php if ( $this->data['showjumplinks'] ): ?>
507507 <!-- jumpto -->
508508 <div id="jump-to-nav">
509 - <?php $this->msg( 'jumpto' ) ?> <a href="#head"><?php $this->msg( 'jumptonavigation' ) ?></a>,
 509+ <?php $this->msg( 'jumpto' ) ?> <a href="#mw-head"><?php $this->msg( 'jumptonavigation' ) ?></a>,
510510 <a href="#p-search"><?php $this->msg( 'jumptosearch' ) ?></a>
511511 </div>
512512 <!-- /jumpto -->

Follow-up revisions

RevisionCommit summaryAuthorDate
r680271.16wmf4: Merge Vector and UsabilityInitiative fixes from trunk: r67836, r678...catrope20:25, 14 June 2010
r68102Backport r67703 & r67893...platonides19:38, 15 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67703Prefix Vector specific ids (head-base|page-base|head|panel) with mw- per bug ......platonides11:28, 9 June 2010

Comments

#Comment by Platonides (talk | contribs)   17:46, 13 June 2010

Thanks. Seems it slipped my greps.

Status & tagging log