r67851 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67850‎ | r67851 | r67852 >
Date:12:51, 11 June 2010
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Added newline
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -49,7 +49,8 @@
5050
5151 $fileName = self::generateFileName( $wgSQLiteDataDir, $dbName );
5252 if ( !is_readable( $fileName ) ) {
53 - throw new DBConnectionError( $this, "SQLite database not accessible" ); $this->mConn = false;
 53+ throw new DBConnectionError( $this, "SQLite database not accessible" );
 54+ $this->mConn = false;
5455 }
5556 $this->openFile( $fileName );
5657 return $this->mConn;

Comments

#Comment by Hashar (talk | contribs)   18:30, 21 October 2010

Is

$this->mConn = false;

really needed since we throw an exception already ?

Status & tagging log