r67773 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67772‎ | r67773 | r67774 >
Date:04:34, 10 June 2010
Author:mah
Status:deferred
Tags:
Comment:
follow-up r66696 — thought I had committed this fix
Modified paths:
  • /trunk/extensions/NewUserMessage/NewUserMessage.class.php (modified) (history)
  • /trunk/extensions/NewUserMessage/NewUserMessage.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/NewUserMessage/NewUserMessage.i18n.php
@@ -15,7 +15,6 @@
1616 $messages['en'] = array(
1717 'newusermessage-desc' => "Adds a message to newly created user's talk pages",
1818 'newuseredit-summary' => 'Adding [[{{int:newusermessage-template}}|welcome message]] to new user\'s talk page',
19 - 'newusermessage-template' => 'Template:Welcome', # The title of the message template
2019 'newusermessage-template-subject' => 'Template:Welcome-subject', # Always substituted. Used if LiquidThreads is enabled in the User_talk namespace. Do not translate or duplicate this message to other languages
2120 'newusermessage-template-body' => 'Template:Welcome-body', # Used if LiquidThreads is enabled in the User_talk namespace. Do not translate or duplicate this message to other languages
2221 'newusermessage-editor' => 'New user message', # The username used for the edit
Index: trunk/extensions/NewUserMessage/NewUserMessage.class.php
@@ -65,10 +65,6 @@
6666 return '';
6767 } elseif ( !$text->exists() ) {
6868 return '';
69 -
70 - if ( $template->getNamespace() == NS_TEMPLATE ) {
71 - $text = $template->getText();
72 - }
7369 }
7470
7571 return $text->getText();

Follow-up revisions

RevisionCommit summaryAuthorDate
r67796Follow-up r67773: Remove message for translatewiki tooraymond10:04, 10 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66696Make template fetching and substitution work. Simplify the code more.mah18:30, 20 May 2010

Status & tagging log