r67760 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67759‎ | r67760 | r67761 >
Date:20:49, 9 June 2010
Author:simetrical
Status:ok
Tags:
Comment:
Make r66504 a little more concise
Modified paths:
  • /trunk/phase3/includes/Xml.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Xml.php
@@ -275,7 +275,8 @@
276276 * @return string HTML
277277 */
278278 public static function input( $name, $size=false, $value=false, $attribs=array() ) {
279 - $attributes = array();
 279+ $attributes = array( 'name' => $name );
 280+
280281 if( $size ) {
281282 $attributes['size'] = $size;
282283 }
@@ -284,8 +285,6 @@
285286 $attributes['value'] = $value;
286287 }
287288
288 - $attributes['name'] = $name;
289 -
290289 return self::element( 'input', $attributes + $attribs );
291290 }
292291

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66504HTML5 fix: Bad value for attribute size on element input: The empty string is...siebrand23:57, 15 May 2010

Status & tagging log