r67759 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r67758‎ | r67759 | r67760 >
Date:20:48, 9 June 2010
Author:simetrical
Status:ok
Tags:
Comment:
Use Html for HTML, not Xml

Better fix than r66502. Html should always be used for HTML output, Xml
should only be used if you're actually doing XML (like Atom or
whatever). Lots of other uses here and elsewhere that should be
corrected.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
——@@ -353,7 +353,7 @@
354354
355355 if( !$this->firstExtOpened ) {
356356 // Insert a spacing line
357 - $out .= '<tr class="sv-space">' . Xml::element( 'td', $opt, '', false ) . "</tr>\n";
 357+ $out .= '<tr class="sv-space">' . Html::element( 'td', $opt ) . "</tr>\n";
358358 }
359359 $this->firstExtOpened = false;
360360

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66502HTML5 fix: short tag not allowed for <td>siebrand23:37, 15 May 2010

Status & tagging log