r67683 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67682‎ | r67683 | r67684 >
Date:05:49, 9 June 2010
Author:skizzerz
Status:ok
Tags:
Comment:
* delete EditUser and GroupPermissionsManager extensions from trunk, as I am no longer maintaining them and they are outdated
* fix bug in CategoryTests extension
* spacing and reference/value stuff fixed in ForcePreview and RegexFunctions extensions
Modified paths:
  • /trunk/extensions/CategoryTests/CategoryTests.php (modified) (history)
  • /trunk/extensions/EditUser (deleted) (history)
  • /trunk/extensions/ForcePreview/ForcePreview.php (modified) (history)
  • /trunk/extensions/GroupPermissionsManager (deleted) (history)
  • /trunk/extensions/RegexFunctions/RegexFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryTests/CategoryTests.php
@@ -30,6 +30,8 @@
3131 $parser->setFunctionHook( 'ifcategory', array( &$wgExtCategoryTests, 'ifcategory' ) );
3232 $parser->setFunctionHook( 'ifnocategories', array( &$wgExtCategoryTests, 'ifnocategories' ) );
3333 $parser->setFunctionHook( 'switchcategory', array( &$wgExtCategoryTests, 'switchcategory' ) );
 34+
 35+ return true;
3436 }
3537
3638 class ExtCategoryTests {
Index: trunk/extensions/ForcePreview/ForcePreview.php
@@ -29,7 +29,7 @@
3030
3131 function efForcePreview( &$editpage, &$buttons ) {
3232 global $wgUser;
33 - if( !$wgUser->isAllowed( 'forcepreviewexempt' ) && !$editpage->preview && empty($editpage->save) ) {
 33+ if( !$wgUser->isAllowed( 'forcepreviewexempt' ) && !$editpage->preview && empty( $editpage->save ) ) {
3434 wfLoadExtensionMessages( 'ForcePreview' );
3535 $buttons['save'] = str_replace( '/>', 'disabled="disabled" />', $buttons['save'] );
3636 $buttons['save'] = preg_replace( '/value="' . wfMsg('savearticle') . '"/i', 'value="' . wfMsg('forcepreview') . '"', $buttons['save'] );
Index: trunk/extensions/RegexFunctions/RegexFunctions.php
@@ -55,7 +55,7 @@
5656 var $modifiers = array('i', 'm', 's', 'x', 'A', 'D', 'S', 'U', 'X', 'J', 'u', 'e');
5757 var $options = array('i', 'm', 's', 'x', 'U', 'X', 'J');
5858
59 - function rmatch ( &$parser, $string = '', &$pattern = '', &$return = '', $notfound = '', $offset = 0 ) {
 59+ function rmatch ( &$parser, $string = '', $pattern = '', $return = '', $notfound = '', $offset = 0 ) {
6060 global $wgRegexFunctionsPerPage, $wgRegexFunctionsAllowModifiers, $wgRegexFunctionsDisable;
6161 if(in_array('rmatch', $wgRegexFunctionsDisable))
6262 return;
@@ -78,7 +78,7 @@
7979 return $return;
8080 }
8181
82 - function rsplit ( &$parser, $string = '', &$pattern = '', $piece = 0 ) {
 82+ function rsplit ( &$parser, $string = '', $pattern = '', $piece = 0 ) {
8383 global $wgRegexFunctionsPerPage, $wgRegexFunctionsAllowModifiers, $wgRegexFunctionsLimit, $wgRegexFunctionsDisable;
8484 if(in_array('rsplit', $wgRegexFunctionsDisable))
8585 return;
@@ -99,7 +99,7 @@
100100 return $res[$p];
101101 }
102102
103 - function rreplace ( &$parser, $string = '', &$pattern = '', &$replace = '' ) {
 103+ function rreplace ( &$parser, $string = '', $pattern = '', &$replace = '' ) {
104104 global $wgRegexFunctionsPerPage, $wgRegexFunctionsAllowModifiers, $wgRegexFunctionsAllowE, $wgRegexFunctionsLimit, $wgRegexFunctionsDisable;
105105 if(in_array('rreplace', $wgRegexFunctionsDisable))
106106 return;

Follow-up revisions

RevisionCommit summaryAuthorDate
r67704Follow-up r67683: Remove deleted extensions from translatewikiraymond11:30, 9 June 2010
r69398Recover EditUser extension and put it up to date with the new preferences.platonides18:30, 15 July 2010

Status & tagging log