r67549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67548‎ | r67549 | r67550 >
Date:18:20, 7 June 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 23797) Xml::input() now allows '0' for the value parameter
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Xml.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Xml.php
@@ -280,7 +280,7 @@
281281 $attributes['size'] = $size;
282282 }
283283
284 - if( $value ) {
 284+ if( $value !== false ) { // maybe 0
285285 $attributes['value'] = $value;
286286 }
287287
Index: trunk/phase3/RELEASE-NOTES
@@ -189,6 +189,7 @@
190190 the $noRedir parameter is set to true
191191 * (bug 23688) Correct mime types for Office 2007 OpenXML documents.
192192 * (bug 23787) Corrected $wgDefaultSkin's comment in DefaultSettings.php
 193+* (bug 23797) Xml::input() now allows '0' for the value parameter
193194
194195 === API changes in 1.17 ===
195196 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r76222Test for r67549 (bug 23797)hashar22:43, 6 November 2010

Comments

#Comment by Hashar (talk | contribs)   22:44, 6 November 2010

test added in r76222

Status & tagging log