r67544 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67543‎ | r67544 | r67545 >
Date:16:19, 7 June 2010
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
(bug 23570) Fix an instance of a javascript: link in core
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -145,7 +145,9 @@
146146 var toggleLink = document.createElement( 'a' );
147147 toggleLink.id = 'togglelink';
148148 toggleLink.className = 'internal';
149 - toggleLink.href = 'javascript:toggleToc()';
 149+ toggleLink.href = '#';
 150+ toggleLink.onclick = toggleToc;
 151+
150152 toggleLink.appendChild( document.createTextNode( tocHideText ) );
151153
152154 outerSpan.appendChild( document.createTextNode( '[' ) );
@@ -187,6 +189,7 @@
188190 document.cookie = "hidetoc=1";
189191 tocmain.className = 'toc tochidden';
190192 }
 193+ return false;
191194 }
192195
193196 var mwEditButtons = [];
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1676,7 +1676,7 @@
16771677 * to ensure that client-side caches do not keep obsolete copies of global
16781678 * styles.
16791679 */
1680 -$wgStyleVersion = '284';
 1680+$wgStyleVersion = '285';
16811681
16821682
16831683 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r677531.16wmf4: Merge some Vector fixes from trunk: r67537, r67544, r67576, r67631,...catrope19:52, 9 June 2010
r68007Fix r67544 per CR: cancel event properly in TOC show/hide click handlercatrope17:51, 14 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67526UsabilityInitiative: (bug 23570) Inserting characters into edit summary field...catrope12:54, 7 June 2010

Comments

#Comment by TheDJ (talk | contribs)   10:57, 12 June 2010
#Comment by Catrope (talk | contribs)   17:51, 14 June 2010

Fixed in r68007.

Status & tagging log