r67211 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67210‎ | r67211 | r67212 >
Date:06:44, 2 June 2010
Author:tstarling
Status:ok
Tags:
Comment:
Allow base paths other than MediaWiki.
Modified paths:
  • /trunk/tools/codereview-proxy/index.php (modified) (history)

Diff [purge]

Index: trunk/tools/codereview-proxy/index.php
@@ -7,7 +7,19 @@
88 ini_set( 'display_errors', false);
99 header('Content-type: application/x-php-serialized');
1010
11 -$data = runAction( "http://svn.wikimedia.org/svnroot/mediawiki" );
 11+$allowedBases = array(
 12+ 'http://svn.wikimedia.org/svnroot/mediawiki',
 13+ 'http://svn.wikimedia.org/svnroot/pywikipedia',
 14+ 'http://svn.wikimedia.org/svnroot/mysql',
 15+);
 16+
 17+$base = inputStr( 'base', $allowedBases[0] );
 18+if ( !in_array( $base, $allowedBases ) ) {
 19+ echo serialize( false );
 20+ exit;
 21+}
 22+
 23+$data = runAction( $base );
1224 echo serialize( $data );
1325
1426 function inputStr( $key, $default=null ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r67212Client-side support for r67211: allow codereview-proxy to work with base path...tstarling06:46, 2 June 2010
r67213MFT r67212: Client-side support for r67211: allow codereview-proxy to work wi...tstarling06:48, 2 June 2010

Status & tagging log