r67114 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67113‎ | r67114 | r67115 >
Date:20:16, 30 May 2010
Author:btongminh
Status:deferred
Tags:
Comment:
Misc fixes for previous commit
Modified paths:
  • /branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AccountManager.i18n.php (modified) (history)
  • /branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AccountManager.php (modified) (history)
  • /branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AmExport.php (modified) (history)
  • /branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AmUserView.php (modified) (history)

Diff [purge]

Index: branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AmExport.php
@@ -66,10 +66,10 @@
6767 $title = SpecialPage::getTitleFor( 'AccountManager' );
6868 $wgOut->setSubtitle( wfMsgExt( 'am-download-subtitle',
6969 array( 'parse', 'replaceafter' ),
70 - Xml::element( 'a', array( 'href' => $title->getLocalURL( 'format=csv') ),
 70+ Xml::element( 'a', array( 'href' => $title->getLocalURL( 'export=csv') ),
7171 wfMsg( 'am-download-cvs' )
7272 ),
73 - Xml::element( 'a', array( 'href' => $title->getLocalURL( 'format=csvexcel') ),
 73+ Xml::element( 'a', array( 'href' => $title->getLocalURL( 'export=csvexcel') ),
7474 wfMsg( 'am-download-cvsexcel' )
7575 )
7676 ) );
Index: branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AccountManager.i18n.php
@@ -21,7 +21,7 @@
2222 'am-users-by-status' => 'Users by status',
2323 'am-download-subtitle' => 'Download user list as $1 ($2)',
2424 'am-download-cvs' => 'CSV',
25 - 'am-download-cvsexcel' => 'CSV semicolon separated',
 25+ 'am-download-cvsexcel' => 'semicolon separated',
2626
2727 'am-rights' => 'rights',
2828 'am-save-changes' => 'Save changes',
Index: branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AccountManager.php
@@ -16,4 +16,3 @@
1717 $wgSpecialPages['AccountManager'] = 'SpecialAccountManager';
1818
1919 $wgUserProperties = array( 'address', 'city' );
20 -$wgUserActivityLevels = array( 'active', 'inactive' );
Index: branches/NssMySQLAuth-rewrite/NssMySQLAuth/AccountManager/AmUserView.php
@@ -58,9 +58,9 @@
5959 $label = $prop;
6060
6161 if ( $prop == 'active' ) {
62 - global $wgUserActivityLevels;
 62+ global $wgActivityModes;
6363 $select = new XmlSelect( $amName, false, 'active' );
64 - foreach ( $wgUserActivityLevels as $level )
 64+ foreach ( $wgActivityModes as $level )
6565 $select->addOption( $level );
6666
6767 $input = $select->getHTML();

Status & tagging log