r67113 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67112‎ | r67113 | r67114 >
Date:20:13, 30 May 2010
Author:platonides
Status:ok
Tags:
Comment:
Remove r44003 workaround. It is no longer needed, we can now use temporary tables again.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -637,10 +637,12 @@
638638 $this->databaseSetupDone = true;
639639 $this->oldTablePrefix = $wgDBprefix;
640640
 641+ # SqlBagOStuff broke when using temporary tables on r40209 (bug 15892).
 642+ # It seems to have been fixed since (r55079?).
 643+ # If it fails, $wgCaches[CACHE_DB] = new HashBagOStuff(); should work around it.
 644+
641645 # CREATE TEMPORARY TABLE breaks if there is more than one server
642 - # FIXME: r40209 makes temporary tables break even with just one server
643 - # FIXME: (bug 15892); disabling the feature entirely as a temporary fix
644 - if ( true || wfGetLB()->getServerCount() != 1 ) {
 646+ if ( wfGetLB()->getServerCount() != 1 ) {
645647 $this->useTemporaryTables = false;
646648 }
647649

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44003(bug 15892) kluge: disable use of temporary tables for parserTests until some...vyznev21:22, 27 November 2008

Status & tagging log