r66898 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66897‎ | r66898 | r66899 >
Date:21:36, 25 May 2010
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Attempt at changing postgres as per r66892

OverlordQ or someone, can you review please?
Modified paths:
  • /trunk/phase3/maintenance/postgres/archives/patch-rename-iwl_prefix.sql (added) (history)
  • /trunk/phase3/maintenance/postgres/tables.sql (modified) (history)
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/postgres/archives/patch-rename-iwl_prefix.sql
@@ -0,0 +1,2 @@
 2+DROP INDEX iwl_prefix;
 3+CREATE INDEX iwl_prefix_from_title ON iwlinks (iwl_prefix, iwl_from, iwl_title);
\ No newline at end of file
Property changes on: trunk/phase3/maintenance/postgres/archives/patch-rename-iwl_prefix.sql
___________________________________________________________________
Name: svn:eol-style
14 + native
Index: trunk/phase3/maintenance/postgres/tables.sql
@@ -622,4 +622,4 @@
623623 iwl_title TEXT NOT NULL DEFAULT ''
624624 );
625625 CREATE UNIQUE INDEX iwl_from ON iwlinks (iwl_from, iwl_prefix, iwl_title);
626 -CREATE INDEX iwl_prefix ON iwlinks (iwl_prefix, iwl_title);
 626+CREATE INDEX iwl_prefix_from_title ON iwlinks (iwl_prefix, iwl_from, iwl_title);
Index: trunk/phase3/maintenance/updaters.inc
@@ -1966,6 +1966,12 @@
19671967 wfOut( "Adding ipb_address_unique index\n" );
19681968 $wgDatabase->sourceFile( archive( 'patch-ipb_address_unique.sql' ) );
19691969 }
 1970+
 1971+ # Fix iwlinks index
 1972+ if ( pg_index_exists( 'iwlinks', 'iwl_prefix' ) ) {
 1973+ wfOut( "Replacing index 'iwl_prefix' with 'iwl_prefix_from_title'...\n" );
 1974+ $wgDatabase->sourceFile( archive( 'patch-ipb_address_unique.sql' ) );
 1975+ }
19701976
19711977 global $wgExtNewTables, $wgExtPGNewFields, $wgExtPGAlteredFields, $wgExtNewIndexes;
19721978 # Add missing extension tables

Follow-up revisions

RevisionCommit summaryAuthorDate
r68892Followup to r66898, source correct patchfileoverlordq17:22, 2 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66892Followup to r65105 after discussion with Roan...reedy20:37, 25 May 2010

Comments

#Comment by OverlordQ (talk | contribs)   17:20, 2 July 2010

Sources the wrong file, but yea, seems fine.

Status & tagging log