r66725 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66724‎ | r66725 | r66726 >
Date:16:23, 21 May 2010
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: (bug 23617) Some tooltips get dropped, no idea why, so just make tooltipping unconditional
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.autoEllipsis.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -64,7 +64,7 @@
6565
6666 // Core functionality of extension scripts
6767 array( 'src' => 'js/plugins/jquery.async.js', 'version' => 3 ),
68 - array( 'src' => 'js/plugins/jquery.autoEllipsis.js', 'version' => 9 ),
 68+ array( 'src' => 'js/plugins/jquery.autoEllipsis.js', 'version' => 10 ),
6969 array( 'src' => 'js/plugins/jquery.browser.js', 'version' => 6 ),
7070 array( 'src' => 'js/plugins/jquery.collapsibleTabs.js', 'version' => 6 ),
7171 array( 'src' => 'js/plugins/jquery.color.js', 'version' => 1 ),
@@ -85,10 +85,10 @@
8686 array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 5 ),
8787 ),
8888 'combined' => array(
89 - array( 'src' => 'js/plugins.combined.js', 'version' => 406 ),
 89+ array( 'src' => 'js/plugins.combined.js', 'version' => 407 ),
9090 ),
9191 'minified' => array(
92 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 406 ),
 92+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 407 ),
9393 ),
9494 ),
9595 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.autoEllipsis.js
@@ -87,9 +87,9 @@
8888 }
8989 break;
9090 }
91 - if ( options.tooltip )
92 - $text.attr( 'title', text );
9391 }
 92+ if ( options.tooltip )
 93+ $text.attr( 'title', text );
9494 cache[text][w] = $text.text();
9595 } );
9696 };
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -5259,9 +5259,9 @@
52605260 }
52615261 break;
52625262 }
5263 - if ( options.tooltip )
5264 - $text.attr( 'title', text );
52655263 }
 5264+ if ( options.tooltip )
 5265+ $text.attr( 'title', text );
52665266 cache[text][w] = $text.text();
52675267 } );
52685268 };
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -365,10 +365,9 @@
366366 if(w in cache[text]){$text.text(cache[text][w]);return;}
367367 $text.text(text);if($text.width()>w){switch(options.position){case'right':var l=0,r=text.length;do{var m=Math.ceil((l+r)/2);$text.text(text.substr(0,m)+'...');if($text.width()>w){r=m-1;}else{l=m;}}while(l<r);$text.text(text.substr(0,l)+'...');break;case'center':var i=[Math.round(text.length/2),Math.round(text.length/2)];var side=1;while($text.outerWidth()>w&&i[0]>0){$text.text(text.substr(0,i[0])+'...'+text.substr(i[1]));if(side==0){i[0]--;side=1;}else{i[1]++;side=0;}}
368368 break;case'left':var r=0;while($text.outerWidth()>w&&r<text.length){$text.text('...'+text.substr(r));r++;}
369 -break;}
 369+break;}}
370370 if(options.tooltip)
371 -$text.attr('title',text);}
372 -cache[text][w]=$text.text();});};})(jQuery);(function($){$.browserTest=function(a,z){var u='unknown',x='X',m=function(r,h){for(var i=0;i<h.length;i=i+1){r=r.replace(h[i][0],h[i][1]);}
 371+$text.attr('title',text);cache[text][w]=$text.text();});};})(jQuery);(function($){$.browserTest=function(a,z){var u='unknown',x='X',m=function(r,h){for(var i=0;i<h.length;i=i+1){r=r.replace(h[i][0],h[i][1]);}
373372 return r;},c=function(i,a,b,c){var r={name:m((a.exec(i)||[u,u])[1],b)};r[r.name]=true;r.version=(c.exec(i)||[x,x,x,x])[3];if(r.name.match(/safari/)&&r.version>400){r.version='2.0';}
374373 if(r.name==='presto'){r.version=($.browser.version>9.27)?'futhark':'linear_b';}
375374 if(r.name==='opera'&&$.browser.version>=9.8){r.version=i.match(/version\/([0-9\.]*)/i)[1]||10;}

Follow-up revisions

RevisionCommit summaryAuthorDate
r667261.16wmf4: MFT r66725catrope16:25, 21 May 2010
r66728Followup to r66725: add tooltip for cache hits as wellcatrope18:09, 21 May 2010

Status & tagging log