r66668 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66667‎ | r66668 | r66669 >
Date:23:36, 19 May 2010
Author:platonides
Status:deferred (Comments)
Tags:
Comment:
Revision 66666!

Little list of things to fix / to do on this extension.
Modified paths:
  • /trunk/extensions/UploadWizard/TODO (added) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/TODO
@@ -0,0 +1,18 @@
 2+You can't use browser back button
 3+Alert box "Please press this button to start your uploads." after pressing a button
 4+<thedj> if i'm on the first page, there are two buttons. "add another file" "upload" and "next". I'm slightly confused about what I should do. Press next, or press upload.
 5+It exposes the local filename http://commons.prototype.wikimedia.org/wiki/File:Jimmy_Wales_being_a_good_citizen.png
 6+Upload with "null" as summary http://commons.prototype.wikimedia.org/w/index.php?title=File:Upload_wizard_deadlock.png&action=edit
 7+Useless? "ZOMG THIS DEED IS NOT READY" message
 8+You can reach to a deadlock situation http://commons.prototype.wikimedia.org/wiki/File:Upload_wizard_deadlock.png
 9+Wizard tabs show a link pointer but you can't browse there.
 10+You are allowed to write new lines in the title (but shall not)
 11+Font size in text fields is too small
 12+Add support for upload from url
 13+mwe-upwiz-secs-remaining message
 14+You can change the upload fields *after* they have been uploaded
 15+No option to add another file after the upload (merge upload with next button?)
 16+"To link to it in HTML, copy this HTML code:" fails for long urls (only the first line is shown, breaks at http://commons.prototype.wikimedia.org)
 17+UploadWizardPage.js contains wiki config. It should be a <script> tag int the page.
 18+Noscript fallback doesn't work (no error either)
 19+Noscript fallback should be a html equivalent Wizard

Comments

#Comment by Catrope (talk | contribs)   20:07, 3 June 2010

Off by 2 error! :P

#Comment by MaxSem (talk | contribs)   20:08, 3 June 2010

That's why people should write unit tests.

#Comment by Aaron Schulz (talk | contribs)   22:17, 3 June 2010

Should have locked the MediaWiki directory first and then committed.

Status & tagging log