r66630 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66629‎ | r66630 | r66631 >
Date:22:05, 18 May 2010
Author:papyromancer
Status:deferred
Tags:
Comment:
quick fix of typo in nativeEmbed
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/nativeEmbed.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/nativeEmbed.js
@@ -92,8 +92,12 @@
9393 var vid = this.getPlayerElement();
9494 if ( typeof this.playerElement != 'undefined' ) {
9595 // Setup some bindings:
96 - // Bind events to local js methods:
97 - vid.addEventListener( 'canplaythrogh', function() { _this.canplaythrough }, true);
 96+ // Bind events to local js methods:
 97+
 98+ // mdale points out this may be the best way to write these:
 99+ // vid.addEventListener( 'canplaythrough', function() { $j( _this ).trigger('canplaythrough'); }, true);
 100+
 101+ vid.addEventListener( 'canplaythrough', function() { _this.canplaythrough() }, true);
98102 vid.addEventListener( 'loadedmetadata', function() { _this.onloadedmetadata() }, true);
99103 vid.addEventListener( 'progress', function( e ) { _this.onprogress( e ); }, true);
100104 vid.addEventListener( 'ended', function() { _this.onended() }, true);

Status & tagging log