r66629 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66628‎ | r66629 | r66630 >
Date:21:54, 18 May 2010
Author:papyromancer
Status:deferred
Tags:
Comment:
* AddMedia checks out with fewer closure errors
* Lines that still produce warnings are marked with comments signed, "-papy"
Modified paths:
  • /branches/MwEmbedStandAlone/modules/AddMedia/jquery.dragDropFile.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/AddMedia/mw.Firefogg.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/AddMedia/mw.FirefoggGUI.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/AddMedia/mw.RemoteSearchDriver.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/AddMedia/mw.Firefogg.js
——@@ -647,7 +647,7 @@
648648 var previewTimer = setInterval( function() {
649649 if ( _this.fogg.status() != "encoding" ) {
650650 clearInterval( previewTimer );
651 - _this.show_preview == false;
 651+ _this.show_preview == false; // Closure compiler marks this as irrelevant -papy
652652 }
653653 if ( _this.show_preview == true ) {
654654 v.load();
Index: branches/MwEmbedStandAlone/modules/AddMedia/mw.FirefoggGUI.js
——@@ -149,9 +149,9 @@
150150 'maxSize' : 1080,
151151 'videoQuality' : 6,
152152 'audioQuality' : 3,
153 - 'noUpscaling' : true,
 153+ 'noUpscaling' : true
154154 }
155 - },
 155+ }
156156 }
157157 },
158158
——@@ -180,7 +180,7 @@
181181 'default' : 1,
182182 'range' : { 'min': -1, 'max': 10 },
183183 'type' : 'slider',
184 - 'group' : 'quality',
 184+ 'group' : 'quality'
185185 },
186186 'videoCodec': {
187187 'default' : "theora",
——@@ -211,7 +211,7 @@
212212 'videoBitrate': {
213213 'range' : { 'min' : 1, 'max' : 16778 },
214214 'type' : "slider",
215 - 'group' : "advVideo",
 215+ 'group' : "advVideo"
216216 } ,
217217 'twopass': {
218218 'type' : "boolean",
——@@ -290,7 +290,7 @@
291291 'group' : 'meta'
292292 },
293293 'license': {
294 - 'type' : 'string',
 294+ 'type' : 'string'
295295 },
296296 'contact': {
297297 'type' : 'string',
Index: branches/MwEmbedStandAlone/modules/AddMedia/mw.RemoteSearchDriver.js
——@@ -529,7 +529,7 @@
530530 * Get license icon html
531531 * @param license_key the license key (ie "by-sa" or "by-nc-sa" etc)
532532 *
533 - * @return {jQuery element} A div containing the license icons.
 533+ * @return {Element} A div containing the license icons.
534534 */
535535 getLicenseIconHtml: function( licenseObj ) {
536536
——@@ -1552,7 +1552,7 @@
15531553 *
15541554 * @param {Object} Object to store in context.
15551555 *
1556 - * @return {function} A callback to retrieve the context.
 1556+ * @return {Function} A callback to retrieve the context.
15571557 */
15581558 storeContext: function( contextObject ) {
15591559 var context = contextObject;
——@@ -2275,7 +2275,7 @@
22762276 /**
22772277 * Check if a given content provider is local.
22782278 * @param {Object} provider Provider object to be checked
2279 - * @return
 2279+ * @return {Boolean}
22802280 */
22812281 isProviderLocal: function( provider ) {
22822282 if ( provider.local ) {
——@@ -2477,7 +2477,7 @@
24782478 _this.doApiImport( resource, function() {
24792479 $j( '#rsd_resource_import' ).remove();
24802480 _this.clipEdit.updateInsertControlActions();
2481 - callback
 2481+ callback // Closure reports that this line is irrelevant -papy
24822482 });
24832483 } else {
24842484 mw.log( "Error: import mode is not form or API (can not copy asset)" );
——@@ -2961,7 +2961,7 @@
29622962 /**
29632963 * Create controls for selecting result display layout (e.g. box, list)
29642964 *
2965 - * @return {jQuery element} The layout element to embed in the page.
 2965+ * @return {Element} The layout element to embed in the page.
29662966 */
29672967 createLayoutSelector: function() {
29682968
——@@ -3030,7 +3030,7 @@
30313031 *
30323032 * @param The current content provider.
30333033 *
3034 - * @return {jQuery element} A description element for embedding.
 3034+ * @return {Element} A description element for embedding.
30353035 */
30363036 createSearchDescription: function( provider ) {
30373037 var resultsFromMsg = gM( 'mwe-results_from',
——@@ -3056,7 +3056,7 @@
30573057 * Results Header controls like box vs list view
30583058 * & search description
30593059 *
3060 - * @return {jQuery element} The header for embedding in the result set.
 3060+ * @return {Element} The header for embedding in the result set.
30613061 */
30623062 createResultsHeader: function() {
30633063 var _this = this;
——@@ -3083,7 +3083,7 @@
30843084 /**
30853085 * Creates the footer of the search results (paging).
30863086 *
3087 - * @return {jQuery element} The footer for embedding in the result set.
 3087+ * @return {Element} The footer for embedding in the result set.
30883088 */
30893089 createResultsFooter: function() {
30903090 var _this = this;
——@@ -3100,7 +3100,7 @@
31013101 /**
31023102 * Generates an HTML control for paging between search results.
31033103 *
3104 - * @return {jQuery element} paging control for current results
 3104+ * @return {Element} paging control for current results
31053105 */
31063106 createPagingControl: function( target ) {
31073107 var _this = this;
——@@ -3197,4 +3197,4 @@
31983198 // Run / update search display:
31993199 this.showResults( );
32003200 }
3201 -};
\ No newline at end of file
 3201+};
Index: branches/MwEmbedStandAlone/modules/AddMedia/jquery.dragDropFile.js
——@@ -48,7 +48,7 @@
4949 $j( 'body' ).append(
5050 $j('<div />')
5151 .attr( {
52 - 'title' : gM( 'mwe-upload-multi', fileCount )
 52+ 'title' : gM( 'mwe-upload-multi', fileCount );
5353 'id' : 'multiple_file_input'
5454 } )
5555 .css({

Status & tagging log