r66606 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66605‎ | r66606 | r66607 >
Date:11:41, 18 May 2010
Author:hartman
Status:ok
Tags:
Comment:
Followup r66566. wgUploadNavigationUrl is an external link.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1992,19 +1992,17 @@
19931993 global $wgUploadNavigationUrl;
19941994
19951995 if( $wgUploadNavigationUrl ) {
1996 - $title = Title::newFromText( $wgUploadNavigationUrl );
 1996+ # Using an empty class attribute to avoid automatic setting of "external" class
 1997+ return $this->makeExternalLink( $wgUploadNavigationUrl, wfMsgHtml( 'upload' ), false, null, array( 'class' => '') );
 1998+ } else {
 1999+ return $this->link(
 2000+ SpecialPage::getTitleFor('Upload'),
 2001+ wfMsgHtml( 'upload' ),
 2002+ array(),
 2003+ array(),
 2004+ array( 'known', 'noclasses' )
 2005+ );
19972006 }
1998 - if( !isset( $title ) ) {
1999 - $title = SpecialPage::getTitleFor('Upload');
2000 - }
2001 -
2002 - return $this->link(
2003 - $title,
2004 - wfMsgHtml( 'upload' ),
2005 - array(),
2006 - array(),
2007 - array( 'known', 'noclasses' )
2008 - );
20092007 }
20102008
20112009 /* these are used extensively in SkinTemplate, but also some other places */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66566Let old skins take into account $wgUploadNavigationUrl....hartman15:15, 17 May 2010

Status & tagging log