r66605 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66604‎ | r66605 | r66606 >
Date:05:28, 18 May 2010
Author:nad
Status:ok
Tags:
Comment:
need to do htnlentities decode on the values in cmpCallback and ensure single quotes are done with ENT_QUOTES constant
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -420,7 +420,7 @@
421421 * - $b is the expression from the recordtable query
422422 */
423423 function cmpCallback( $a, $b, $operator ) {
424 - $b = preg_replace( "|([/'])|", "\\$1", $b );
 424+ $b = str_replace( '/', '\/', html_entity_decode( $b, ENT_QUOTES ) );
425425 switch ( $operator ) {
426426 case '=':
427427 $cond = preg_match( "/$b/i", $a );

Status & tagging log