r66561 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66560‎ | r66561 | r66562 >
Date:12:40, 17 May 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Drop <code> from install step. No wikitext in these messages and no need to introduce it just for this.
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.i18n.php
——@@ -425,7 +425,7 @@
426426 'config-insecure-secretkey' => "'''Warning:''' Unable to create secure <code>\$wgSecretKey</code>.
427427 Consider changing it manually.",
428428 'config-install-sysop' => 'Creating administrator user account',
429 - 'config-install-localsettings' => 'Creating <code>LocalSettings.php</code>',
 429+ 'config-install-localsettings' => 'Creating LocalSettings.php',
430430 'config-install-localsettings-unwritable' => 'Warning: Could not write <code>LocalSettings.php</code>.
431431 Create it yourself, using the following text:',
432432 'config-install-done' => "'''Congratulations!'''

Comments

#Comment by Nikerabbit (talk | contribs)   13:44, 17 May 2010

How about the very next line or the one two lines above?

#Comment by Hashar (talk | contribs)   13:36, 3 November 2010

Marking 'fixme'. As per Nikerabbit comment either :

  • remove everywhere
  • keep it there for config-install-localsettings
#Comment by 😂 (talk | contribs)   14:15, 3 November 2010

  • This msg no longer exists
  • Using <code> works in the install msgs nowadays, just tested
#Comment by Hashar (talk | contribs)   09:28, 20 November 2010

ok :)

Status & tagging log