r66395 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66394‎ | r66395 | r66396 >
Date:21:07, 13 May 2010
Author:mark
Status:deferred
Tags:
Comment:
Remove callback in case we closed the connection.
Modified paths:
  • /trunk/routing/twistedbgp/src/bgp.py (modified) (history)

Diff [purge]

Index: trunk/routing/twistedbgp/src/bgp.py
@@ -1164,7 +1164,10 @@
11651165
11661166 # Don't do anything if we closed the connection explicitly ourselves
11671167 if self.disconnected:
1168 - self.deferred.callback(True)
 1168+ # Callback sessionEstablished shouldn't be called, especially not
 1169+ # with an argument protocol = True. Calling errback doesn't seem
 1170+ # appropriate either. Just do nothing?
 1171+ #self.deferred.callback(True)
11691172 self.factory.connectionClosed(self)
11701173 return
11711174

Follow-up revisions

RevisionCommit summaryAuthorDate
r66396pybal (0.1+r66395) lucid; urgency=low...mark21:12, 13 May 2010

Status & tagging log