r66278 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66277‎ | r66278 | r66279 >
Date:18:06, 12 May 2010
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Don't break old wikis using Renameuser

This needs to be done for all the extensions that had their entry points
renamed, where possible. (There was one I spotted that only differed in
case, and we can't have two filenames differ only in case because of all
the poor Windows users out there.) The status quo will reliably cause
*lots* of wikis to break on update to 1.17, any that use any affected
extension. On top of that, it causes your wiki to break whenever you
switch back and forth between trunk and a branch with the same
LocalSettings.php.
Modified paths:
  • /trunk/extensions/Renameuser/SpecialRenameuser.php (added) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/SpecialRenameuser.php
——@@ -0,0 +1 @@
 2+<?php require dirname( __FILE__ ) . '/Renameuser.php';
Property changes on: trunk/extensions/Renameuser/SpecialRenameuser.php
___________________________________________________________________
Name: svn:eol-style
13 + native

Comments

#Comment by Platonides (talk | contribs)   21:34, 19 May 2010

I'm not convinced that we should support the filename changes across releases. This kinda moots the rename.

Perhaps we should mark it as deprecated (where? how?) and remove the alias on next release?

#Comment by Simetrical (talk | contribs)   14:42, 21 May 2010

No. IMO, this is absolutely unacceptable. You're guaranteeing that manual reconfiguration is needed on old wikis, and that it's impossible to do development on multiple branches with the same LocalSettings.php, for absolutely no reason. The old names need to be present, and need to be kept indefinitely, not just for one or two releases. They don't hurt anything; you can just ignore them if you don't like them. Breaking stuff for no reason other than someone's sense of aesthetics is not a tenable way to do software development. The change makes it harder to do actual development and discourages users from upgrading, for no detectable gain whatsoever.

#Comment by Aaron Schulz (talk | contribs)   16:27, 21 May 2010

I'd tend to agree with Aryeh here.

Also, MW doc pages were not updated and people were complaining about installation errors.

#Comment by Mike.lifeguard (talk | contribs)   16:31, 21 May 2010

I got hit on a few extensions. Trivial to fix, I don't see why you wouldn't want sensible filenames. But it'd be nice to know your wiki's about to break :)

I assume someone can do some svn magic to find the renamed files & I shouldn't bother checking my wiki for them?

Status & tagging log