r66258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66257‎ | r66258 | r66259 >
Date:06:31, 12 May 2010
Author:bawolff
Status:ok
Tags:
Comment:
Special:Userrights didn't recognize user as self if person didn't capitalize
the first letter of their name, and thus wouldn't honour $wgGroupsAddToSelf
if user accidently forgot to capitalize their name.

Possibly a regression from r57064
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
@@ -77,7 +77,7 @@
7878 $this->mTarget = $wgUser->getName();
7979 }
8080
81 - if ( $this->mTarget == $wgUser->getName() )
 81+ if ( User::getCanonicalName( $this->mTarget ) == $wgUser->getName() )
8282 $this->isself = true;
8383
8484 if( !$this->userCanChangeRights( $wgUser, true ) ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -162,6 +162,7 @@
163163 MediaWiki:Subject-preview when previewing summary
164164 * (bug 23426) The {{REVISIONMONTH}} variable is now zero-padded and added new
165165 variable {{REVISIONMONTH1}} when unpadded version is needed.
 166+* Special:Userrights didn't recognize user as changing his/her own rights if user did not capitalize first letter of username.
166167
167168 === API changes in 1.17 ===
168169 * (bug 22738) Allow filtering by action type on query=logevent

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57064Fix regression from r54429 "(bug 17864 + bug 19519) - Do input normalization ...brion17:27, 29 September 2009

Status & tagging log