r54429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54428‎ | r54429 | r54430 >
Date:04:42, 5 August 2009
Author:mrzman
Status:resolved (Comments)
Tags:
Comment:
(bug 17864 + bug 19519) - Do input normalization on the username before doing existence/permission checks
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
@@ -54,6 +54,7 @@
5555 } else {
5656 $this->mTarget = $wgRequest->getVal( 'user' );
5757 }
 58+ $this->mTarget = User::getCanonicalName( $this->mTarget );
5859
5960 /*
6061 * If the user is blocked and they only have "partial" access
Index: trunk/phase3/RELEASE-NOTES
@@ -390,6 +390,7 @@
391391 and issue with Opera (bug 18497) where fullscreen mode is assumed to be
392392 projection mode and the style sheet for screen media is no longer used.
393393 * (bug 16084) Default memory limit has be increased to 50M, see $wgMemoryLimit
 394+* (bug 17864/19519) Added proper input normalization in Special:UserRights
394395
395396 == API changes in 1.16 ==
396397

Follow-up revisions

RevisionCommit summaryAuthorDate
r57064Fix regression from r54429 "(bug 17864 + bug 19519) - Do input normalization ...brion17:27, 29 September 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   17:18, 29 September 2009

Causes regression in access to remote users where dbname includes an underscore

#Comment by Brion VIBBER (talk | contribs)   17:27, 29 September 2009

Fixed in r57064

Status & tagging log