r66064 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66063‎ | r66064 | r66065 >
Date:13:23, 8 May 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 23429) Added new hook WatchlistEditorBuildRemoveLine
* one indentation fix in WatchlistEditor.php
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1796,6 +1796,13 @@
17971797 $user: user that watched
17981798 $article: article object watched
17991799
 1800+'WatchlistEditorBuildRemoveLine': when building remove lines in
 1801+ Special:Watchlist/edit
 1802+&$tools: array of extra links
 1803+$title: Title object
 1804+$redirect: whether the page is a redirect
 1805+$skin: Skin object
 1806+
18001807 'WikiExporter::dumpStableQuery': Get the SELECT query for "stable" revisions
18011808 dumps
18021809 One, and only one hook should set this, and return false.
Index: trunk/phase3/includes/WatchlistEditor.php
@@ -431,10 +431,13 @@
432432 array( 'known', 'noclasses' )
433433 );
434434 }
 435+
 436+ wfRunHooks( 'WatchlistEditorBuildRemoveLine', array( &$tools, $title, $redirect, $skin ) );
 437+
435438 return "<li>"
436439 . Xml::check( 'titles[]', false, array( 'value' => $title->getPrefixedText() ) )
437440 . $link . " (" . $wgLang->pipeList( $tools ) . ")" . "</li>\n";
438 - }
 441+ }
439442
440443 /**
441444 * Show a form for editing the watchlist in "raw" mode
Index: trunk/phase3/RELEASE-NOTES
@@ -69,6 +69,7 @@
7070 is no title match in search and the user has no rights to create pages.
7171 * Added $wgJQueryVersion, $wgJQueryMinified and $wgJQueryOnEveryPage (true by
7272 default) to configure loading of jQuery by MediaWiki
 73+* (bug 23429) Added new hook WatchlistEditorBuildRemoveLine
7374
7475 === Bug fixes in 1.17 ===
7576 * (bug 17560) Half-broken deletion moved image files to deletion archive

Comments

#Comment by 😂 (talk | contribs)   04:23, 5 December 2010

What is the use case for this?

#Comment by IAlex (talk | contribs)   19:23, 6 December 2010

To add extra links (or whatever else) to the entries.

#Comment by 😂 (talk | contribs)   19:51, 6 December 2010

Don't really see why, but ok :)

Status & tagging log