r66030 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66029‎ | r66030 | r66031 >
Date:17:54, 7 May 2010
Author:jeroendedauw
Status:resolved (Comments)
Tags:
Comment:
Added Svips O_o patch.
Modified paths:
  • /trunk/extensions/Awesomeness/Awesomeness.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Awesomeness/Awesomeness.php
@@ -38,4 +38,12 @@
3939 }
4040
4141 return true;
 42+}
 43+
 44+/**
 45+ * Based on Svips patch at http://bug-attachment.wikimedia.org/attachment.cgi?id=7351
 46+ */
 47+if ( strtolower( $_SERVER['QUERY_STRING'] ) == 'o_o' ) {
 48+ header( 'Content-Type: text/plain' );
 49+ die( $_SERVER['QUERY_STRING'] == 'O_o' ? 'o_O' : 'O_o' );
4250 }
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r66036Follow up to r66030 - applied Reedy's patchjeroendedauw18:46, 7 May 2010

Comments

#Comment by MaxSem (talk | contribs)   17:57, 7 May 2010

Doesn't support similar important smilies, such as MY favorite o_0.

#Comment by Jeroen De Dauw (talk | contribs)   17:58, 7 May 2010

I accept patches... :D

#Comment by Reedy (talk | contribs)   18:31, 7 May 2010

switch (strtolower( $_SERVER['QUERY_STRING'] )) { case 'o_o': die( $_SERVER['QUERY_STRING'] == 'O_o' ? 'o_O' : 'O_o' );

case 'o_0': die( '0_o' );

case '0_o': die( 'o_0' ); }

Status & tagging log