r66012 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66011‎ | r66012 | r66013 >
Date:13:34, 7 May 2010
Author:svip
Status:deferred
Tags:
Comment:
Made parameters case insensitive.
Modified paths:
  • /trunk/extensions/TemplateAdventures/TemplateAdventures.i18n.magic.php (modified) (history)
  • /trunk/extensions/TemplateAdventures/Templates/Citation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TemplateAdventures/TemplateAdventures.i18n.magic.php
@@ -14,9 +14,9 @@
1515 'ta_cc_editorsurname' => array( 0, 'editorsurname' ),
1616 'ta_cc_editorgiven' => array( 0, 'editorgiven' ),
1717 'ta_cc_editorlink' => array( 0, 'editorlink' ),
18 - 'ta_cc_url' => array( 0, 'url', 'URL' ),
19 - 'ta_cc_title' => array( 0, 'title', 'Title' ),
20 - 'ta_cc_pmc' => array( 0, 'pmc', 'PMC' ),
 18+ 'ta_cc_url' => array( 0, 'url' ),
 19+ 'ta_cc_title' => array( 0, 'title' ),
 20+ 'ta_cc_pmc' => array( 0, 'pmc' ),
2121 'ta_cc_includedworktitle' => array( 0, 'includedworktitle' ),
2222 'ta_cc_periodical' => array( 0, 'periodical' ),
2323 'ta_cc_transitalic' => array( 0, 'transitalic' ),
Index: trunk/extensions/TemplateAdventures/Templates/Citation.php
@@ -400,6 +400,7 @@
401401 * well as its numeral found with it or false if not.
402402 */
403403 protected function parseOptionName( $value ) {
 404+ global $wgContLang;
404405
405406 static $magicWords = null;
406407 if ( $magicWords === null ) {
@@ -423,6 +424,8 @@
424425 $num = null;
425426 }
426427
 428+ $name = $wgContLang->lc( $name );
 429+
427430 if ( $name = $magicWords->matchStartToEnd( trim($name) ) ) {
428431 return array(
429432 str_replace( 'ta_cc_', '', $name ),

Status & tagging log