r66011 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66010‎ | r66011 | r66012 >
Date:13:28, 7 May 2010
Author:demon
Status:ok
Tags:
Comment:
Fix jQuery support since we now version it
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerOutput.php
@@ -112,7 +112,7 @@
113113 <?php echo "var dbTypes = " . Xml::encodeJsVar( $dbTypes ) . ";\n"; ?>
114114 // -->
115115 </script>
116 - <script type="text/javascript" src="../skins/common/jquery.min.js"></script>
 116+ <?php $this->outputJQuery(); ?>
117117 <script type="text/javascript" src="../skins/common/config.js"></script>
118118 </head>
119119
@@ -168,6 +168,7 @@
169169 }
170170
171171 function outputShortHeader() {
 172+
172173 ?>
173174 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
174175 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en" dir="ltr">
@@ -177,7 +178,7 @@
178179 <title><?php $this->outputTitle(); ?></title>
179180 <link rel="stylesheet" type="text/css" href="../skins/monobook/main.css"/>
180181 <link rel="stylesheet" type="text/css" href="../skins/common/config.css"/>
181 - <script type="text/javascript" src="../skins/common/jquery.min.js"></script>
 182+ <?php $this->outputJQuery(); ?>
182183 <script type="text/javascript" src="../skins/common/config.js"></script>
183184 </head>
184185
@@ -190,6 +191,12 @@
191192 echo htmlspecialchars( wfMsg( 'config-title', $wgVersion ) );
192193 }
193194
 195+ function outputJQuery() {
 196+ global $wgJQueryVersion;
 197+ echo '<script type="text/javascript" src="../skins/common/jquery-' .
 198+ $wgJQueryVersion . '.min.js"></script>';
 199+ }
 200+
194201 function outputWarnings() {
195202 $this->addHTML( $this->warnings );
196203 $this->warnings = '';

Status & tagging log