r66006 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66005‎ | r66006 | r66007 >
Date:11:30, 7 May 2010
Author:svip
Status:deferred
Tags:
Comment:
Follow up to r66005, fixed minor issue in writer section creation function.
Modified paths:
  • /trunk/extensions/TemplateAdventures/Templates/Citation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TemplateAdventures/Templates/Citation.php
@@ -199,7 +199,7 @@
200200 if ( $writer[1][1] == null )
201201 continue;
202202 $tmp .= $writer[1][1];
203 - if ( $editor[1][0] != null )
 203+ if ( $writer[1][0] != null )
204204 $tmp .= $this->getSeparator( 'name' ) . $writer[1][0];
205205 } else {
206206 # maybe we shan't support no surname/given name structure

Follow-up revisions

RevisionCommit summaryAuthorDate
r66007Follow up to r66005 and r66006; I feel like such an idiot. Totally forgot to...svip11:31, 7 May 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66005Further updates to citation, yet not done.svip11:23, 7 May 2010

Status & tagging log