r65974 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65973‎ | r65974 | r65975 >
Date:00:31, 6 May 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r64113, bug 22905: incorrect DML regex causing mishandling of <abbr>
Modified paths:
  • /branches/wmf/1.16wmf4 (modified) (history)
  • /branches/wmf/1.16wmf4/CREDITS (modified) (history)
  • /branches/wmf/1.16wmf4/RELEASE-NOTES (modified) (history)
  • /branches/wmf/1.16wmf4/includes (modified) (history)
  • /branches/wmf/1.16wmf4/includes/parser/Parser.php (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/maintenance/parserTests.txt
@@ -6398,6 +6398,15 @@
63996399 !! end
64006400
64016401 !! test
 6402+Bug 22905: <abbr> followed by ISBN followed by </a>
 6403+!! input
 6404+<abbr>(fr)</abbr> ISBN 2753300917 [http://www.example.com example.com]
 6405+!! result
 6406+<p><abbr>(fr)</abbr> <a href="https://www.mediawiki.org/wiki/Special:BookSources/2753300917" class="internal mw-magiclink-isbn">ISBN 2753300917</a> <a href="http://www.example.com" class="external text" rel="nofollow">example.com</a>
 6407+</p>
 6408+!! end
 6409+
 6410+!! test
64026411 Double RFC
64036412 !! input
64046413 RFC RFC 1234
Index: branches/wmf/1.16wmf4/CREDITS
@@ -114,6 +114,7 @@
115115 * ST47
116116 * Scott Colcord
117117 * Simon Walker
 118+* Solitarius
118119 * Stefano Codari
119120 * Str4nd
120121 * svip
Index: branches/wmf/1.16wmf4/includes/parser/Parser.php
@@ -976,7 +976,7 @@
977977 $urlChar = self::EXT_LINK_URL_CLASS;
978978 $text = preg_replace_callback(
979979 '!(?: # Start cases
980 - (<a.*?</a>) | # m[1]: Skip link text
 980+ (<a[ \t\r\n>].*?</a>) | # m[1]: Skip link text
981981 (<.*?>) | # m[2]: Skip stuff inside HTML elements' . "
982982 (\\b(?:$prots)$urlChar+) | # m[3]: Free external links" . '
983983 (?:RFC|PMID)\s+([0-9]+) | # m[4]: RFC or PMID, capture number
Property changes on: branches/wmf/1.16wmf4/includes
___________________________________________________________________
Modified: svn:mergeinfo
984984 Merged /trunk/phase3/includes:r64113
Index: branches/wmf/1.16wmf4/RELEASE-NOTES
@@ -17,6 +17,7 @@
1818
1919 * The maintenance script system was overhauled. Most maintenance scripts now
2020 have a useful help page when you run them with --help.
 21+* (bug 22905) Correctly handle <abbr> followed by ISBN
2122
2223 * AdminSettings.php is no longer required in order to run maintenance scripts.
2324 You can just set $wgDBadminuser and $wgDBadminpassword in your
Property changes on: branches/wmf/1.16wmf4
___________________________________________________________________
Modified: svn:mergeinfo
2425 Merged /trunk/phase3:r64113

Follow-up revisions

RevisionCommit summaryAuthorDate
r65975Merged all changes from trunk/extensions/Collection up to HEAD (r65974)tstarling00:50, 6 May 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64113Correctly handle <abbr> followed by ISBN...simetrical13:42, 24 March 2010

Status & tagging log