r65945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65944‎ | r65945 | r65946 >
Date:09:05, 5 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6 - Added seperate settings for maps width and height for maps in forms
Modified paths:
  • /trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInputs.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_QueryPrinters.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SM_Settings.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/SM_Settings.php
@@ -51,21 +51,8 @@
5252
5353
5454
 55+# Queries
5556
56 -
57 -
58 -# Geographical Coordinate data type settings
59 -
60 -# Integer. The default distance value to be used in geographical distance queries.
61 -# This value will only be used when the user does not provide one.
62 -$smgGeoCoordDistance = 5;
63 -
64 -
65 -
66 -
67 -
68 -# Query Printers
69 -
7057 # Boolean. The default value for the forceshow parameter. Will force a map to be shown even when there are no query results
7158 # when set to true. This value will only be used when the user does not provide one.
7259 $smgQPForceShow = false;
@@ -84,3 +71,18 @@
8572
8673 # Boolean. Indicates if coordinates should be outputted in directional notation by default.
8774 $smgQPCoodDirectional = $egMapsCoordinateDirectional;
 75+
 76+# Integer. The default distance value to be used in geographical distance queries.
 77+# This value will only be used when the user does not provide one.
 78+$smgGeoCoordDistance = 5;
 79+
 80+
 81+
 82+
 83+
 84+# Forms
 85+
 86+# Integer or string. The default width and height of maps in forms created by using Semantic Forms.
 87+# These values only be used when the user does not provide them.
 88+$smgFIWidth = 665;
 89+$smgFIHeight = $egMapsMapHeight;
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if ( defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' ) ) {
39 - define( 'SM_VERSION', '0.6 a20' );
 39+ define( 'SM_VERSION', '0.6 rc1' );
4040
4141 $smgScriptPath = ( isset( $wgExtensionAssetsPath ) && $wgExtensionAssetsPath ? $wgExtensionAssetsPath : $wgScriptPath . '/extensions' ) . '/SemanticMaps';
4242 $smgDir = dirname( __FILE__ ) . '/';
Index: trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInputs.php
@@ -58,8 +58,15 @@
5959
6060 private static function initializeParams() {
6161 global $egMapsAvailableServices, $egMapsDefaultServices, $egMapsAvailableGeoServices, $egMapsDefaultGeoService;
 62+ global $smgFIWidth, $smgFIHeight;
6263
6364 self::$parameters = array(
 65+ 'width' => array(
 66+ 'default' => $smgFIWidth
 67+ ),
 68+ 'height' => array(
 69+ 'default' => $smgFIHeight
 70+ ),
6471 'centre' => array(
6572 'aliases' => array( 'center' ),
6673 ),
Index: trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_QueryPrinters.php
@@ -55,10 +55,16 @@
5656 }
5757
5858 private static function initializeParams() {
59 - global $egMapsDefaultServices, $egMapsAvailableGeoServices, $egMapsDefaultGeoService;
 59+ global $egMapsDefaultServices, $egMapsAvailableGeoServices, $egMapsDefaultGeoService, $egMapsMapWidth, $egMapsMapHeight;
6060 global $smgQPForceShow, $smgQPShowTitle, $smgQPTemplate;
6161
6262 self::$parameters = array(
 63+ 'width' => array(
 64+ 'default' => $egMapsMapWidth
 65+ ),
 66+ 'height' => array(
 67+ 'default' => $egMapsMapHeight
 68+ ),
6369 'geoservice' => array(
6470 'criteria' => array(
6571 'in_array' => $egMapsAvailableGeoServices

Follow-up revisions

RevisionCommit summaryAuthorDate
r65946Follow up to r65945jeroendedauw09:06, 5 May 2010

Status & tagging log