r65905 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65904‎ | r65905 | r65906 >
Date:16:03, 4 May 2010
Author:platonides
Status:resolved (Comments)
Tags:
Comment:
Specifying --run-disabled with --regex should run the tests matching the regex (disabled or not), and *only them*. Not all tests!
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -1687,8 +1687,8 @@
16881688 if (!isset( $data['config'] ) )
16891689 $data['config'] = '';
16901690
1691 - if ( $this->parser && (preg_match('/\\bdisabled\\b/i', $data['options'])
1692 - || !preg_match("/{$this->parser->regex}/i", $data['test'])) && !$this->parser->runDisabled ) {
 1691+ if ( $this->parser && (preg_match('/\\bdisabled\\b/i', $data['options']) && !$this->parser->runDisabled)
 1692+ || !preg_match("/{$this->parser->regex}/i", $data['test']) ) {
16931693 # disabled test
16941694 $data = array();
16951695 $section = null;

Follow-up revisions

RevisionCommit summaryAuthorDate
r65973fix logic error that spews warnings in r65905mah23:54, 5 May 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   23:54, 5 May 2010

This spews warnings

 PHP Notice:  Trying to get property of non-object in maintenance/parserTests.inc on line 1697

Status & tagging log