Index: trunk/phase3/includes/db/DatabaseOracle.php |
— | — | @@ -307,12 +307,14 @@ |
308 | 308 | if ( ( $this->mLastResult = $stmt = oci_parse( $this->mConn, $sql ) ) === false ) { |
309 | 309 | $e = oci_error( $this->mConn ); |
310 | 310 | $this->reportQueryError( $e['message'], $e['code'], $sql, __FUNCTION__ ); |
| 311 | + return false; |
311 | 312 | } |
312 | 313 | |
313 | 314 | if ( oci_execute( $stmt, $this->execFlags() ) == false ) { |
314 | 315 | $e = oci_error( $stmt ); |
315 | 316 | if ( !$this->ignore_DUP_VAL_ON_INDEX || $e['code'] != '1' ) { |
316 | 317 | $this->reportQueryError( $e['message'], $e['code'], $sql, __FUNCTION__ ); |
| 318 | + return false; |
317 | 319 | } |
318 | 320 | } |
319 | 321 | |
— | — | @@ -494,6 +496,7 @@ |
495 | 497 | $val = ( $wgLang != null ) ? $wgLang->checkTitleEncoding( $val ) : $val; |
496 | 498 | if ( oci_bind_by_name( $stmt, ":$col", $val ) === false ) { |
497 | 499 | $this->reportQueryError( $this->lastErrno(), $this->lastError(), $sql, __METHOD__ ); |
| 500 | + return false; |
498 | 501 | } |
499 | 502 | } else { |
500 | 503 | if ( ( $lob[$col] = oci_new_descriptor( $this->mConn, OCI_D_LOB ) ) === false ) { |
— | — | @@ -518,6 +521,7 @@ |
519 | 522 | |
520 | 523 | if ( !$this->ignore_DUP_VAL_ON_INDEX || $e['code'] != '1' ) { |
521 | 524 | $this->reportQueryError( $e['message'], $e['code'], $sql, __METHOD__ ); |
| 525 | + return false; |
522 | 526 | } else { |
523 | 527 | $this->mAffectedRows = oci_num_rows( $stmt ); |
524 | 528 | } |